mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Roland Dreier <rdreier@cisco.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Early hang with 2.6.21-rc4-rt1
Date: Tue, 27 Mar 2007 21:22:30 +0200	[thread overview]
Message-ID: <20070327192230.GA31695@elte.hu> (raw)
In-Reply-To: <adavegpl0jd.fsf@cisco.com>


* Roland Dreier <rdreier@cisco.com> wrote:

> Any suggestion of where to look?  My /proc/latency_trace stays 
> stubbornly empty -- are there any sysctls I need to change from their 
> default to get latency tracing?  I'm a complete noob when it comes to 
> the -rt patch, so I'm not sure what the right way to use the tracing 
> infrastructure to track down this lost rtc interrupts issue is.

please apply the patch below, from Steve - this should fix the tracer.

	Ingo

---------------------->
Ingo,

I wasn't able to turn on latency tracing on a x86_64 box. Using logdev
to see what was happening, I found that echoing 0
into /proc/sys/kernel/preempt_max_latency would only change the max from
-1ULL to 0xffffffff00000000. Which would keep the max pretty high still.

The problem is in sysctl.c where preempt_max_latency can be modified. On
systems where cycle_t is greater than the size of int (x86_64) we only
write to the 4 LSB.

Here's the patch:

-- Steve

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Index: linux-2.6.21-rc5/kernel/sysctl.c
===================================================================
--- linux-2.6.21-rc5.orig/kernel/sysctl.c
+++ linux-2.6.21-rc5/kernel/sysctl.c
@@ -287,17 +287,17 @@ static ctl_table kern_table[] = {
 		.ctl_name	= CTL_UNNUMBERED,
 		.procname	= "preempt_max_latency",
 		.data		= &preempt_max_latency,
-		.maxlen		= sizeof(int),
+		.maxlen		= sizeof(preempt_max_latency),
 		.mode		= 0644,
-		.proc_handler	= &proc_dointvec,
+		.proc_handler	= &proc_doulongvec_minmax,
 	},
 	{
 		.ctl_name	= CTL_UNNUMBERED,
 		.procname	= "preempt_thresh",
 		.data		= &preempt_thresh,
-		.maxlen		= sizeof(int),
+		.maxlen		= sizeof(preempt_thresh),
 		.mode		= 0644,
-		.proc_handler	= &proc_dointvec,
+		.proc_handler	= &proc_doulongvec_minmax,
 	},
 #endif
 #ifdef CONFIG_EVENT_TRACE


  reply	other threads:[~2007-03-27 19:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-25  5:03 Roland Dreier
2007-03-25  5:29 ` Roland Dreier
2007-03-25  7:29   ` Ingo Molnar
2007-03-25  7:34     ` Ingo Molnar
2007-03-25  8:06       ` Ingo Molnar
2007-03-25 16:27         ` Roland Dreier
2007-03-25  7:31 ` Ingo Molnar
2007-03-25 14:35   ` Roland Dreier
2007-03-25 17:01     ` Roland Dreier
2007-03-27 19:22       ` Ingo Molnar [this message]
2007-03-27 19:24       ` Ingo Molnar
2007-03-27 19:42         ` Roland Dreier
2007-03-30  9:02           ` Ingo Molnar
2007-03-30  9:24             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070327192230.GA31695@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®