mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@in.ibm.com>
To: Horms <horms@verge.net.au>
Cc: fastboot@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] kdump/kexec: calculate note size at compile time
Date: Wed, 28 Mar 2007 13:38:53 +0530	[thread overview]
Message-ID: <20070328080853.GE4941@in.ibm.com> (raw)
In-Reply-To: <20070328071315.GC29303@verge.net.au>

On Wed, Mar 28, 2007 at 04:13:20PM +0900, Horms wrote:
[..]
> 
> DESC is probably a better name that BODY here, I meant to update
> that before posting. An updated version is below.
> 
> > > +#define KEXEC_NOTE_BYTES ( (KEXEC_NOTE_HEAD_BYTES * 2) + \
> > 
> > Why are we multiplying KEXEC_NOTE_HEAD_BYTES with 2?
> 
> The way that the note merging code works in vmcore it assumes that
> the area is a list of notes. And there is a terminating note that
> has all the header values set to 0, and nothing else. So the time 2
> is for the space to store the terminating note.
> 

Ok.. Got it. Looks fine to me. 

Thanks
Vivek

  reply	other threads:[~2007-03-28  8:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-28  6:18 Simon Horman
2007-03-28  6:43 ` Vivek Goyal
2007-03-28  7:13   ` Horms
2007-03-28  8:08     ` Vivek Goyal [this message]
2007-03-29  3:30       ` Simon Horman
2007-03-29  3:44         ` Vivek Goyal
2007-03-29  3:48           ` Simon Horman
2007-03-30  0:41         ` Andrew Morton
2007-03-30  2:34           ` Simon Horman
2007-04-02  4:48           ` Simon Horman
2007-04-02 10:10             ` Simon Horman
2007-04-03  9:37 Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070328080853.GE4941@in.ibm.com \
    --to=vgoyal@in.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=fastboot@lists.linux-foundation.org \
    --cc=horms@verge.net.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome