From: Pete Zaitcev <zaitcev@redhat.com>
To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Cc: "Jiri Kosina" <jkosina@suse.cz>,
linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, stuart_hayes@dell.com,
zaitcev@redhat.com
Subject: Re: usb hid: reset NumLock
Date: Fri, 30 Mar 2007 12:54:37 -0700 [thread overview]
Message-ID: <20070330125437.b3229471.zaitcev@redhat.com> (raw)
In-Reply-To: <d120d5000703301114r420a9604i34b6a015e6bad285@mail.gmail.com>
On Fri, 30 Mar 2007 14:14:20 -0400, "Dmitry Torokhov" <dmitry.torokhov@gmail.com> wrote:
> > I didn't like a) layering violation, and b) that they defeat filtering
> > unconditionally. Why have any filtering then?
> >
> > Instead, I propose for USB HID driver to reset NumLock on probe. Like this:
> >
> > --- a/drivers/usb/input/hid-core.c
> This is fine and that's what we do in atkbd probe but maybe we should
> move that in input core and reset leds as part of
> input_register_device()?
Sure, as long as it works. I think (as much as I understand), that we
already attempt to do this indirectly. input_register_device invokes
->start handlers, and the kbd_start attempts to reset LEDs, but fails
because of the state filtering.
-- Pete
next prev parent reply other threads:[~2007-03-30 19:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 17:59 Pete Zaitcev
2007-03-30 18:14 ` Dmitry Torokhov
2007-03-30 19:54 ` Pete Zaitcev [this message]
2007-03-30 20:29 ` Dmitry Torokhov
2007-03-31 19:35 ` Jiri Kosina
2007-03-31 22:43 ` Pete Zaitcev
2007-04-02 5:24 ` Pete Zaitcev
2007-04-02 14:48 ` Jiri Kosina
2007-04-02 23:12 ` Pete Zaitcev
2007-04-03 5:04 ` Dmitry Torokhov
2007-04-03 6:24 ` Pete Zaitcev
2007-04-03 8:52 ` Jiri Kosina
2007-04-03 8:57 ` [linux-usb-devel] " Robert Marquardt
2007-04-03 9:32 ` Jiri Kosina
2007-04-05 3:24 ` Dmitry Torokhov
2007-04-05 8:50 ` Jiri Kosina
2007-04-05 20:38 ` Pete Zaitcev
2007-04-05 20:54 ` Dmitry Torokhov
2007-04-05 21:22 ` Pete Zaitcev
2007-04-01 11:49 ` Pekka Enberg
2007-04-01 16:16 ` Pete Zaitcev
2007-04-02 4:10 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070330125437.b3229471.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=stuart_hayes@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome