From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753720AbXCaRly (ORCPT ); Sat, 31 Mar 2007 13:41:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753722AbXCaRly (ORCPT ); Sat, 31 Mar 2007 13:41:54 -0400 Received: from smtp.osdl.org ([65.172.181.24]:58423 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753717AbXCaRlx (ORCPT ); Sat, 31 Mar 2007 13:41:53 -0400 Date: Sat, 31 Mar 2007 10:41:44 -0700 From: Andrew Morton To: Greg KH Cc: Ken Chen , Jan Engelhardt , Linux Kernel Mailing List Subject: Re: [patch] remove artificial software max_loop limit Message-Id: <20070331104144.46c85f27.akpm@linux-foundation.org> In-Reply-To: <20070331170743.GB14596@kroah.com> References: <20070330141524.5f6cff29.akpm@linux-foundation.org> <20070331170743.GB14596@kroah.com> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 31 Mar 2007 10:07:43 -0700 Greg KH wrote: > On Fri, Mar 30, 2007 at 02:15:24PM -0700, Andrew Morton wrote: > > On Fri, 30 Mar 2007 02:25:37 -0700 > > "Ken Chen" wrote: > > > > > -module_param(max_loop, int, 0); > > > -MODULE_PARM_DESC(max_loop, "Maximum number of loop devices (1-256)"); > > > > So.. this change will cause a fatal error for anyone who is presently > > using max_loop, won't it? If they're doing that within their > > initramfs/initrd/etc then things could get rather ugly for them. > > > > I don't know how much of a problem this will be in practice - do people use > > max_loop much? > > Yes, the distros do, and they recommend it to their users a lot. Thanks. In that case I think we should retain the max_loop module parameter for now. Ken, when you respin that patch could you restore max_loop, and make its use trigger a warning along the lines of "loop: the max_loop option is obsolete and will be removed in March 2008"?