From: Randy Dunlap <randy.dunlap@oracle.com>
To: bryan.wu@analog.com
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blackfin arch: use boot_command_line instead of save_command_line in setup c file
Date: Wed, 4 Apr 2007 08:07:52 -0700 [thread overview]
Message-ID: <20070404080752.4c2375b2.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1175668103.10608.39.camel@roc-desktop>
On Wed, 04 Apr 2007 14:28:23 +0800 Wu, Bryan wrote:
>
> Signed-off-by: Bryan Wu <bryan.wu@analog.com>
> ---
> arch/blackfin/kernel/setup.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/blackfin/kernel/setup.c b/arch/blackfin/kernel/setup.c
> index ce51882..9870c60 100644
> --- a/arch/blackfin/kernel/setup.c
> +++ b/arch/blackfin/kernel/setup.c
> @@ -221,7 +221,7 @@ void __init setup_arch(char **cmdline_p)
>
> /* Keep a copy of command line */
> *cmdline_p = &command_line[0];
> - memcpy(saved_command_line, command_line, COMMAND_LINE_SIZE);
> + memcpy(boot_command_line, command_line, COMMAND_LINE_SIZE);
> saved_command_line[COMMAND_LINE_SIZE - 1] = 0;
>
> /* setup memory defaults from the user config */
> --
Hi Bryan,
Patch descriptions should include _why_ a change is being made,
not just what the change is.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-04-04 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 6:28 Wu, Bryan
2007-04-04 15:07 ` Randy Dunlap [this message]
2007-04-05 3:21 ` Wu, Bryan
2007-04-05 3:53 ` [PATCH] blackfin arch: use boot_command_line instead of saved_command_line " Wu, Bryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070404080752.4c2375b2.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome