From: lepton <ytht.net@gmail.com>
To: lkm <linux-kernel@vger.kernel.org>
Subject: [PATCH] 2.6.20.4 fix kernel panic on corrupted reiserfs directory
Date: Thu, 5 Apr 2007 14:41:40 +0800 [thread overview]
Message-ID: <20070405064140.GA19620@router.lepton.home> (raw)
Hi,
When reading corrupted reiserfs directory data, d_reclen
could be a negative number, then memcpy will overflow
kernel stack. This can lead to kernel panic.
The following patch adds a sanity check. (against 2.6.20.4)
Signed-off-by: Lepton Wu <ytht.net@gmail.com>
diff -pru linux-2.6/fs/reiserfs/dir.c linux-2.6-lepton/fs/reiserfs/dir.c
--- linux-2.6/fs/reiserfs/dir.c 2007-02-20 14:34:32.000000000 +0800
+++ linux-2.6-lepton/fs/reiserfs/dir.c 2007-04-05 14:35:58.000000000 +0800
@@ -121,6 +121,11 @@ static int reiserfs_readdir(struct file
/* it is hidden entry */
continue;
d_reclen = entry_length(bh, ih, entry_num);
+ if (d_reclen < 0) {
+ pathrelse(&path_to_entry);
+ ret = -EIO;
+ goto out;
+ }
d_name = B_I_DEH_ENTRY_FILE_NAME(bh, ih, deh);
if (!d_name[d_reclen - 1])
d_reclen = strlen(d_name);
O
next reply other threads:[~2007-04-05 6:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 6:41 lepton [this message]
2007-04-05 7:34 ` Alexander E. Patrakov
2007-04-05 13:22 ` lepton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070405064140.GA19620@router.lepton.home \
--to=ytht.net@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®