From: Eric Dumazet <dada1@cosmosbay.com>
To: Vasily Averin <vvs@sw.ru>
Cc: "David S. Miller" <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>,
Andrew Morton <akpm@linux-foundation.org>,
netfilter-devel@lists.netfilter.org, rusty@rustcorp.com.au,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devel@openvz.org
Subject: Re: [PATCH 2.6.21-rc6] [netfilter] early_drop imrovement
Date: Fri, 6 Apr 2007 10:24:33 +0200 [thread overview]
Message-ID: <20070406102433.d3a670a5.dada1@cosmosbay.com> (raw)
In-Reply-To: <4615FE1D.80206@sw.ru>
On Fri, 06 Apr 2007 12:00:29 +0400
Vasily Averin <vvs@sw.ru> wrote:
> When the number of conntracks is reached ip_conntrack_max limit, early_drop() is
> called and tries to free one of already used conntracks in one of the hash
> buckets. If it does not find any conntracks that may be freed, it
> leads to transmission errors.
> However it is not fair because of current hash bucket may be empty but the
> neighbour ones can have the number of conntracks that can be freed. With the
> following patch early_drop() will search conntracks in all hash buckets.
Have you tested your patch in a DOS situation ?
Some machines have a huge ip_conntrack_max.
A single scan of the whole table might take 1000 ms or even more.
next prev parent reply other threads:[~2007-04-06 8:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 8:00 Vasily Averin
2007-04-06 8:24 ` Eric Dumazet [this message]
2007-04-06 10:26 ` Vasily Averin
2007-04-06 15:08 ` Patrick McHardy
2007-04-07 11:45 ` [PATCH nf-2.6.22] " Vasily Averin
2007-04-07 12:08 ` Eric Dumazet
2007-04-08 5:02 ` Vasily Averin
2007-05-09 6:59 ` [NETFILTER] early_drop() imrovement (v3) Vasily Averin
2007-06-25 13:53 ` Patrick McHardy
2007-06-25 14:36 ` Jan Engelhardt
2007-06-26 13:20 ` Vasily Averin
2007-06-26 13:27 ` Patrick McHardy
2007-06-27 8:46 ` [NETFILTER] early_drop() imrovement (v4) Vasily Averin
2007-06-27 8:52 ` Patrick McHardy
2007-06-27 12:04 ` Patrick McHardy
2007-06-27 12:29 ` Vasily Averin
2007-06-27 12:51 ` Patrick McHardy
2007-06-27 13:02 ` Vasily Averin
2007-06-27 13:18 ` Patrick McHardy
2007-06-27 13:25 ` Vasily Averin
2007-06-27 13:28 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2007-04-06 7:48 [PATCH 2.6.21-rc6] [netfilter] early_drop imrovement Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070406102433.d3a670a5.dada1@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=rusty@rustcorp.com.au \
--cc=vvs@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®