Re: [PATCH] kernel-doc: handle spaces in array size

[Randy Dunlap <randy.dunlap@oracle.com>]

On Fri, 6 Apr 2007 21:24:48 +0200 (MEST) Jan Engelhardt wrote:

> On Apr 6 2007 11:47, Randy Dunlap wrote:
> >
> >Unfortunately, kernel-doc has problems with a struct field like this:
> >	uint8_t databuf[NAND_MAX_PAGESIZE + NAND_MAX_OOBSIZE];
> >
> >simply due to the spaces around the "+" sign, so drop all spaces inside
> >[...] so that parsing is done correctly (in some sense).
> >

...

> 
> 	while($arg =~ s/\[(.*)\s+(.*)\]/[$1$2]/) {
> 	}
> 
> should do it, and saves us the pre-matching. (Also note the + at \s)
> (No need to escape [ and ] in the target pattern.)

Yep, that works.  Want to send it with sign-off or shall I just
send a new patch to akpm?

> I can also offer this gem which should do it the most saving way by
> matching the inside of [] exactly once, and otherwise
> matching/replacing only on \s:
> 
> 	$arg =~ s{\[(.*)\]}{($_=$1)=~s/\s+//g;"[$_]"}e;
> 
> (I already hear everyone screaming... ;-)

No, thanks.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***