mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Roland McGrath <roland@redhat.com>
Subject: Re: mm snapshot broken-out-2007-04-07-03-27.tar.gz uploaded
Date: Sat, 7 Apr 2007 10:53:28 -0700	[thread overview]
Message-ID: <20070407105328.836902d1.akpm@linux-foundation.org> (raw)
In-Reply-To: <46178ECC.2030107@googlemail.com>

On Sat, 07 Apr 2007 14:30:04 +0200 Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:

> akpm@linux-foundation.org napisał(a):
> > The mm snapshot broken-out-2007-04-07-03-27.tar.gz has been uploaded to
> > 
> >    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-04-07-03-27.tar.gz
> > 
> > It contains the following patches against 2.6.21-rc6:
> > 
> 
> LTP triggered a ptrace problem.
> 
> ------------[ cut here ]------------
> kernel BUG at kernel/ptrace.c:1281!

umm, Roland, if you're going to add assertions which only function with
CONFIG_PREEMPT enabled, you'd better test with CONFIG_PREEMPT enabled ;)


From: Andrew Morton <akpm@linux-foundation.org>

We hold read_lock(tasklist_lock) in here.

Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/ptrace.c |    2 --
 1 file changed, 2 deletions(-)

diff -puN kernel/ptrace.c~utrace-fix-bug kernel/ptrace.c
--- a/kernel/ptrace.c~utrace-fix-bug
+++ a/kernel/ptrace.c
@@ -1278,8 +1278,6 @@ found:
 		 current->pid, tsk->pid, p->pid, exit_code,
 		 p->exit_state, p->exit_signal);
 
-	NO_LOCKS;
-
 	/*
 	 * If there was a group exit in progress, all threads report that
 	 * status.  Most will have SIGKILL in their own exit_code.
_



  reply	other threads:[~2007-04-07 17:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-07 10:29 akpm
2007-04-07 12:30 ` Michal Piotrowski
2007-04-07 17:53   ` Andrew Morton [this message]
2007-04-07 18:09     ` Michal Piotrowski
2007-04-07 18:38       ` Andrew Morton
2007-04-07 18:48         ` Michal Piotrowski
2007-04-07 20:13           ` Andrew Morton
2007-04-07 20:19             ` Michal Piotrowski
2007-04-07 21:22               ` Michal Piotrowski
2007-04-07 19:43 ` Michal Piotrowski
2007-04-07 20:10   ` Andrew Morton
2007-04-08 12:42     ` Pavel Machek
2007-04-08 13:26 ` Michal Piotrowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070407105328.836902d1.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome