mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: peter.p.waskiewicz.jr@intel.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	jgarzik@pobox.com, cramerj@intel.com, auke-jan.h.kok@intel.com,
	christopher.leech@intel.com
Subject: Re: [PATCH 2/2] NET: Multiqueue network device support.
Date: Mon, 09 Apr 2007 13:46:31 -0700 (PDT)	[thread overview]
Message-ID: <20070409.134631.71091422.davem@davemloft.net> (raw)
In-Reply-To: <D5C1322C3E673F459512FB59E0DDC329029E3EE5@orsmsx414.amr.corp.intel.com>

From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Date: Mon, 9 Apr 2007 13:43:11 -0700

> True, but the assignment for "dev" above also casts this void * to
> struct net_device *:
> 
>         dev = (struct net_device *)
>                 (((long)p + NETDEV_ALIGN_CONST) & ~NETDEV_ALIGN_CONST);
>         dev->padded = (char *)dev - (char *)p;
> 
> Shall I remove my cast?

I think so.  Casts tend to be red flags during patch review,
so don't add them when not necessary and let's remove the
unnecessary ones too.

  reply	other threads:[~2007-04-09 20:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070409204908.31370.9954.stgit@gitlost.site>
     [not found] ` <20070409205052.31370.97137.stgit@gitlost.site>
2007-04-09 20:37   ` David Miller
2007-04-09 20:43     ` Waskiewicz Jr, Peter P
2007-04-09 20:46       ` David Miller [this message]
2007-04-09 20:47         ` Waskiewicz Jr, Peter P
2007-04-09 21:04           ` David Miller
2007-04-11 10:49       ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070409.134631.71091422.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=auke-jan.h.kok@intel.com \
    --cc=christopher.leech@intel.com \
    --cc=cramerj@intel.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®