From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC] pata_icside driver
Date: Mon, 9 Apr 2007 12:36:27 +0100 [thread overview]
Message-ID: <20070409113627.GB26874@flint.arm.linux.org.uk> (raw)
In-Reply-To: <461A1FC1.50809@garzik.org>
On Mon, Apr 09, 2007 at 07:13:05AM -0400, Jeff Garzik wrote:
> It should be noted, mainly for russell's benefit, that the ->irq_ack()
> hook is only called if a debug define is manually enabled in libata.h,
> in a single callsite.
>
> The number of people that actually use the hook -- kernel hackers
> debugging screaming interrupts -- can probably be counted on one hand.
Ok, in that case it makes sense for me to set this to ata_dummy_irq_ack
since I don't have any additional status registers specific to the
interface.
Presumably a similar change to pata_platform.c would be appropriate?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-04-09 11:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 11:00 [PATCH] Provide dummy devm_ioport_* if !HAS_IOPORT Russell King
2007-03-30 11:08 ` [RFC] pata_platform for ARM RiscPC Russell King
2007-04-08 10:18 ` [RFC] pata_icside driver Russell King
2007-04-08 18:59 ` Alan Cox
2007-04-09 1:03 ` Jeff Garzik
2007-04-09 9:56 ` Alan Cox
2007-04-09 10:56 ` Jeff Garzik
2007-04-09 11:13 ` Jeff Garzik
2007-04-09 11:36 ` Russell King [this message]
2007-04-09 12:02 ` Jeff Garzik
2007-04-08 20:09 ` Alan Cox
2007-04-09 8:18 ` Russell King
2007-04-09 8:24 ` Roland Dreier
2007-04-09 8:44 ` Russell King
2007-04-09 10:25 ` Alan Cox
2007-04-09 11:33 ` Russell King
2007-04-21 15:09 ` Russell King
2007-04-09 11:32 ` [RFC] pata_platform for ARM RiscPC Jeff Garzik
2007-03-30 11:08 ` [PATCH] Provide dummy devm_ioport_* if !HAS_IOPORT Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070409113627.GB26874@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®