From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Nishanth Menon <nm@ti.com>, MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-pm <linux-pm@vger.kernel.org>,
Kevin <khilman@deeprootsystems.com>,
lkml <linux-kernel@vger.kernel.org>,
lo <linux-omap@vger.kernel.org>, Jack <jack@embed.me.uk>,
Alexander <holler@ahsoftware.de>
Subject: Re: [PATCH 0/4] OPP usage fixes for RCU locking
Date: Fri, 18 Jan 2013 23:28:22 +0100 [thread overview]
Message-ID: <2007041.tOt4VKpdOD@vostro.rjw.lan> (raw)
In-Reply-To: <1358538755-29109-1-git-send-email-nm@ti.com>
On Friday, January 18, 2013 01:52:31 PM Nishanth Menon wrote:
> Hi,
> Despite being documented in function documentation and in
> Documentation/power/opp.txt, many of the users of OPP APIs
> dont honor RCU lock usage appropriately.
>
> This recently appeared in IRC discussion earlier today [1].
> I did an audit of current usage and the following series
> is a result of this.
>
> NOTE:
> 1. The patch "PM / devfreq: exynos4_bus: honor RCU lock usage" has only
> been build tested as I dont have an exynos platform to try it on. I have
> tried to make it as least intrusive as possible and at least reviewed
> to ensure I haven't screwed anything up.
>
> Other than this, I have added appropriate tested by information in requisite
> patches.
Thanks for the fixes.
MyungJoo, do you want me to take the devfreq ones too?
Rafael
> Series is based off: v3.8-rc4 tag
> Also available in the following location[2]:
> https://github.com/nmenon/linux-2.6-playground branch: post/pm/opp-fixes-v1
>
> Nishanth Menon (4):
> cpufreq: OMAP: use RCU locks around usage of OPP
> cpufreq: cpufreq-cpu0: use RCU locks around usage of OPP
> PM / devfreq: add locking documentation for recommend_opp
> PM / devfreq: exynos4_bus: honor RCU lock usage
>
> drivers/cpufreq/cpufreq-cpu0.c | 5 +++
> drivers/cpufreq/omap-cpufreq.c | 3 ++
> drivers/devfreq/devfreq.c | 5 +++
> drivers/devfreq/exynos4_bus.c | 94 ++++++++++++++++++++++++++++------------
> 4 files changed, 80 insertions(+), 27 deletions(-)
>
> [1] http://www.beagleboard.org/irclogs/index.php?date=2013-01-18#T14:14:07
> [2] https://github.com/nmenon/linux-2.6-playground/commits/post/pm/opp-fixes-v1
>
> Regards,
> Nishanth Menon
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-01-18 22:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 19:52 Nishanth Menon
2013-01-18 19:52 ` [PATCH 1/4] cpufreq: OMAP: use RCU locks around usage of OPP Nishanth Menon
2013-01-18 19:52 ` [PATCH 2/4] cpufreq: cpufreq-cpu0: " Nishanth Menon
2013-01-18 19:52 ` [PATCH 3/4] PM / devfreq: add locking documentation for recommended_opp Nishanth Menon
2013-01-18 19:52 ` [PATCH 4/4] PM / devfreq: exynos4_bus: honor RCU lock usage Nishanth Menon
2013-01-18 22:28 ` Rafael J. Wysocki [this message]
2013-01-21 5:45 ` [PATCH 0/4] OPP usage fixes for RCU locking MyungJoo Ham
2013-01-21 12:40 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2007041.tOt4VKpdOD@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=holler@ahsoftware.de \
--cc=jack@embed.me.uk \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®