From: Wang Zhenyu <zhenyu.z.wang@intel.com>
To: Dave Jones <davej@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Eric Anholt <eric@anholt.net>, Keith Packard <keithp@keithp.com>
Subject: [PATCH] intel_agp: fix G965 GTT size detect
Date: Tue, 10 Apr 2007 09:42:48 +0800 [thread overview]
Message-ID: <20070410014248.GA17932@zhen-devel.sh.intel.com> (raw)
Dave,
On G965, I810_PGETBL_CTL is a mmio offset, but we wrongly take it
as pci config space offset in detecting GTT size. This one line patch
fixs this.
Signed-off-by: Wang Zhenyu <zhenyu.z.wang@intel.com>
---
diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
index a9fdbf9..4c05c71 100644
--- a/drivers/char/agp/intel-agp.c
+++ b/drivers/char/agp/intel-agp.c
@@ -431,9 +431,8 @@ static void intel_i830_init_gtt_entries(
if (IS_I965) {
u32 pgetbl_ctl;
-
- pci_read_config_dword(agp_bridge->dev, I810_PGETBL_CTL,
- &pgetbl_ctl);
+ pgetbl_ctl = readl(intel_i830_private.registers+I810_PGETBL_CTL);
+
/* The 965 has a field telling us the size of the GTT,
* which may be larger than what is necessary to map the
* aperture.
---
next reply other threads:[~2007-04-10 1:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 1:42 Wang Zhenyu [this message]
2007-04-10 2:10 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070410014248.GA17932@zhen-devel.sh.intel.com \
--to=zhenyu.z.wang@intel.com \
--cc=davej@redhat.com \
--cc=eric@anholt.net \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome