On Mon, 2 Apr 2007 07:38:34 +0200 Willy Tarreau wrote: > Hello, > > On Sun, Apr 01, 2007 at 05:14:07PM +0300, Tal Kelrich wrote: > > (resent due to mailer stupidity) > > Hello, > > > > This is my first submitted kernel patch, please be gentle. > > > > Tested and working on AAEON GENE-6310B Subcompact Board > > (also configured for same by default, should work elsewhere) > > patch is against kernel 2.4.34.2 > > > > Changes/Features: > > > > Added ioctl support > > Disables watchdog on driver load > > Supports timeout in seconds > > Timeout defaults to 2 minutes > > No longer under NetWinder arch > > Configurable output GP (defaults to GP16) > > Configurable base IO address > > Non standard read only proc interface for status (/proc/watchdog) > > > > Caveats: > > > > No idea if this breaks netwinder, although it really shouldn't > > Only tested with GP16 > > Utterly ignores inability to get its IO port, mostly because it's > > already taken. I didn't know a way around that. > > release_region is called regardless of having acquired the region, > > this might be trouble. > > While I have no particular problem merging your other driver since it > did not previously exist, I don't like much this one being massively > changed like this, particularly when you cannot test whether it breaks > its original platform (netwinder). I've also noticed that your patch > removes some locking, so I'm even doubting that it will not break > NetWinder. > > A less risky solution would be to make a new driver of it (eg: > w93977.c instead of wdt977.c). Also, if you proceed like this, please > do not forget to write an entry in Configure.help. > > Regards, > Willy > Updated with your comments in mind, now a seperate driver, added info to Configure.help Regards, Tal Kelrich -- Tal Kelrich PGP fingerprint: 3EDF FCC5 60BB 4729 AB2F CAE6 FEC1 9AAC 12B9 AA69 Key Available at: http://www.hasturkun.com/pub.txt ---- "I'm a mean green mother from outer space" -- Audrey II, The Little Shop of Horrors ----