mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jörn Engel" <joern@lazybastard.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Nate Diller <nate.diller@gmail.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/13] fs: convert core functions to zero_user_page
Date: Wed, 11 Apr 2007 16:54:22 +0200	[thread overview]
Message-ID: <20070411145420.GB3531@lazybastard.org> (raw)
In-Reply-To: <20070410225638.476cf89b.akpm@linux-foundation.org>

On Tue, 10 April 2007 22:56:38 -0700, Andrew Morton wrote:
> 
> And I'm surprised that this:
> 
> +static inline void memclear_highpage_flush(struct page *page, unsigned int offset, unsigned int size)
> +{
> +	return zero_user_page(page, offset, size);
> +}
> 
> compiled.  zero_user_page() returns void...

As does memclear_highpage_flush().  Some of my code looks like:
void some_func(...)
{
	if (foo)
		return do_foo(...);
	if (bar)
		return do_bar(...);
	...
}

do_foo() and do_bar() also return void.  Saves an extra line for the
return statment and the brackets.

Doesn't help in the code you quoted, of course.

Jörn

-- 
Measure. Don't tune for speed until you've measured, and even then
don't unless one part of the code overwhelms the rest.
-- Rob Pike

      parent reply	other threads:[~2007-04-11 14:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-11  3:36 Nate Diller
2007-04-11  3:36 ` [PATCH 5/13] ext4: use zero_user_page Nate Diller
2007-04-11  4:14   ` Andreas Dilger
2007-04-11  3:36 ` [PATCH 10/13] reiser4: " Nate Diller
2007-04-11  3:36 ` [PATCH 12/13] xfs: " Nate Diller
2007-04-11  3:36 ` [PATCH 6/13] gfs2: " Nate Diller
2007-04-11  3:36 ` [PATCH 2/13] affs: " Nate Diller
2007-04-11  3:36 ` [PATCH 3/13] ecryptfs: " Nate Diller
2007-04-11  3:36 ` [PATCH 9/13] ocfs2: " Nate Diller
2007-04-11  3:36 ` [PATCH 8/13] ntfs: " Nate Diller
2007-04-11  3:36 ` [PATCH 13/13] fs: deprecate memclear_highpage_flush Nate Diller
2007-04-11  5:58   ` Andrew Morton
2007-04-11  3:36 ` [PATCH 11/13] reiserfs: use zero_user_page Nate Diller
2007-04-11  3:36 ` [PATCH 7/13] nfs: " Nate Diller
2007-04-11  3:36 ` [PATCH 4/13] ext3: " Nate Diller
2007-04-11  5:56 ` [PATCH 1/13] fs: convert core functions to zero_user_page Andrew Morton
2007-04-11  6:14   ` Nate Diller
2007-04-11 14:54   ` Jörn Engel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070411145420.GB3531@lazybastard.org \
    --to=joern@lazybastard.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nate.diller@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®