From: Daniel Walker <dwalker@mvista.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, johnstul@us.ibm.com, tglx@linutronix.de
Subject: [PATCH] i386 tsc: remove xtime_lock'ing around cpufreq notifier
Date: Wed, 11 Apr 2007 09:29:04 -0700 [thread overview]
Message-ID: <20070411162904.232696302@mvista.com> (raw)
The locking of the xtime_lock around the cpu notifier is unessesary now. At one
time the tsc was used after a frequency change for timekeeping, but the re-write
of timekeeping no longer uses the TSC unless the frequency is constant.
The variables that are changed in this section of code had also once been used
for timekeeping, but not any longer ..
Signed-Off-By: Daniel Walker <dwalker@mvista.com>
---
arch/i386/kernel/tsc.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
Index: linux-2.6.20/arch/i386/kernel/tsc.c
===================================================================
--- linux-2.6.20.orig/arch/i386/kernel/tsc.c
+++ linux-2.6.20/arch/i386/kernel/tsc.c
@@ -200,13 +200,10 @@ time_cpufreq_notifier(struct notifier_bl
{
struct cpufreq_freqs *freq = data;
- if (val != CPUFREQ_RESUMECHANGE && val != CPUFREQ_SUSPENDCHANGE)
- write_seqlock_irq(&xtime_lock);
-
if (!ref_freq) {
if (!freq->old){
ref_freq = freq->new;
- goto end;
+ return 0;
}
ref_freq = freq->old;
loops_per_jiffy_ref = cpu_data[freq->cpu].loops_per_jiffy;
@@ -237,9 +234,6 @@ time_cpufreq_notifier(struct notifier_bl
}
}
}
-end:
- if (val != CPUFREQ_RESUMECHANGE && val != CPUFREQ_SUSPENDCHANGE)
- write_sequnlock_irq(&xtime_lock);
return 0;
}
--
--
next reply other threads:[~2007-04-11 16:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-11 16:29 Daniel Walker [this message]
2007-04-11 20:31 ` Andrew Morton
2007-04-11 20:54 ` Daniel Walker
2007-04-11 21:33 ` Andrew Morton
2007-04-12 0:39 ` Andrew Morton
2007-04-12 9:36 ` Andi Kleen
2007-04-12 16:23 ` Andrew Morton
2007-04-12 16:45 ` Andi Kleen
2007-04-12 17:00 ` Andrew Morton
2007-04-12 17:43 ` Jeremy Fitzhardinge
2007-04-12 17:46 ` Andi Kleen
2007-04-12 17:52 ` Daniel Walker
2007-04-12 17:55 ` Andrew Morton
2007-04-12 18:27 ` Andi Kleen
2007-04-12 19:41 ` Jeremy Fitzhardinge
2007-04-12 19:43 ` Jeremy Fitzhardinge
2007-04-12 17:41 ` Jeremy Fitzhardinge
2007-04-12 17:45 ` Andi Kleen
2007-04-12 19:46 ` Jeremy Fitzhardinge
2007-04-12 20:15 ` Andi Kleen
2007-04-12 17:17 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070411162904.232696302@mvista.com \
--to=dwalker@mvista.com \
--cc=akpm@linux-foundation.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome