From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161339AbXDKWym (ORCPT ); Wed, 11 Apr 2007 18:54:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161342AbXDKWyi (ORCPT ); Wed, 11 Apr 2007 18:54:38 -0400 Received: from canuck.infradead.org ([209.217.80.40]:55517 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161340AbXDKWyF (ORCPT ); Wed, 11 Apr 2007 18:54:05 -0400 Date: Wed, 11 Apr 2007 15:51:25 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, netdev@vger.kernel.org, Stephen Hemminger Subject: [patch 04/31] skge: turn carrier off when down Message-ID: <20070411225125.GE24814@kroah.com> References: <20070411224329.866978349@mini.kroah.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="skge-carrier.patch" In-Reply-To: <20070411225100.GA24814@kroah.com> User-Agent: Mutt/1.5.14 (2007-02-12) X-Bad-Reply: References and In-Reply-To but no 'Re:' in Subject. Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org -stable review patch. If anyone has any objections, please let us know. ------------------ From: Stephen Hemminger Driver needs to turn off carrier when down, otherwise it can confuse bonding and bridging and looks like carrier is on immediately when it is brought back up. Signed-off-by: Stephen Hemminger Signed-off-by: Greg Kroah-Hartman --- drivers/net/skge.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/skge.c +++ b/drivers/net/skge.c @@ -2462,6 +2462,7 @@ static int skge_down(struct net_device * printk(KERN_INFO PFX "%s: disabling interface\n", dev->name); netif_stop_queue(dev); + netif_carrier_off(dev); if (hw->chip_id == CHIP_ID_GENESIS && hw->phy_type == SK_PHY_XMAC) cancel_rearming_delayed_work(&skge->link_thread); --