From: Andrew Morton <akpm@linux-foundation.org>
To: Andi Kleen <ak@novell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add keyboard blink driver
Date: Thu, 12 Apr 2007 12:37:04 -0700 [thread overview]
Message-ID: <20070412123704.62963654.akpm@linux-foundation.org> (raw)
In-Reply-To: <200704122128.08869.ak@novell.com>
On Thu, 12 Apr 2007 21:28:08 +0200
Andi Kleen <ak@novell.com> wrote:
> > I wonder if this facility would be more effective if it were to use
> > schedule_delayed_work(). That way, we're using more of the kernel and it
> > will more reliably detect kernel deadness.
>
> Hmm, maybe
??
> +static void do_blink(unsigned long data)
> +{
> + static long count;
> + if (panic_blink)
> + panic_blink(count++);
> + blink_timer.expires = jiffies + msecs_to_jiffies(1);
> + add_timer(&blink_timer);
> +}
> +
> +static int blink_init(void)
> +{
> + printk(KERN_INFO "Enabling keyboard blinking\n");
> + do_blink(0);
> + return 0;
> +}
Would it be better to just not start the timer at all if panic_blink==0?
That would improve life rather a lot for people who link this into vmlinux
but don't have i8042.
next prev parent reply other threads:[~2007-04-12 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 15:27 Andi Kleen
2007-04-12 19:10 ` Andrew Morton
2007-04-12 19:28 ` Andi Kleen
2007-04-12 19:37 ` Andrew Morton [this message]
2007-04-18 12:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070412123704.62963654.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®