On Tue 10-04-07 19:27:22, Andrew Morton wrote: > And shouldn't offset be called prev_offset? Or should prev_page be called > page? Or index? Or prev_index? Or Marmaduke? The naming is all a mess. > > Wanna take a look at all of this, please? OK, attached is a patch which changes prev_page to prev_index and offset to prev_offset. It's still a bit misleading that in mm/filemap.c, variables with page-numbers are called _index while in mm/readahead.c they are often called just offset... But let's leave it for next time. Honza -- Jan Kara SuSE CR Labs