From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] worker_thread: don't play with SIGCHLD
Date: Fri, 13 Apr 2007 11:29:10 +0400 [thread overview]
Message-ID: <20070413072910.GA1522@tv-sign.ru> (raw)
depends on Eric's
kthread-dont-depend-on-work-queues-take-2.patch
worker_thread() inherits ignored SIGCHLD from its parent, kthreadd.
We can remove unneeded do_sigaction().
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- OLD/kernel/workqueue.c~wt 2007-04-05 12:20:35.000000000 +0400
+++ OLD/kernel/workqueue.c 2007-04-13 11:21:43.000000000 +0400
@@ -289,7 +289,6 @@ static int worker_thread(void *__cwq)
{
struct cpu_workqueue_struct *cwq = __cwq;
DEFINE_WAIT(wait);
- struct k_sigaction sa;
if (!cwq->wq->freezeable)
current->flags |= PF_NOFREEZE;
@@ -300,12 +299,6 @@ static int worker_thread(void *__cwq)
*/
numa_default_policy();
- /* SIG_IGN makes children autoreap: see do_notify_parent(). */
- sa.sa.sa_handler = SIG_IGN;
- sa.sa.sa_flags = 0;
- siginitset(&sa.sa.sa_mask, sigmask(SIGCHLD));
- do_sigaction(SIGCHLD, &sa, (struct k_sigaction *)0);
-
for (;;) {
if (cwq->wq->freezeable)
try_to_freeze();
next reply other threads:[~2007-04-13 7:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-13 7:29 Oleg Nesterov [this message]
2007-04-13 13:21 ` Eric W. Biederman
2007-04-13 13:40 ` Oleg Nesterov
2007-04-13 13:54 ` [PATCH] worker_thread: don't play with SIGCHLD and numa policy Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070413072910.GA1522@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®