mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: greg@uclinux.org
Cc: michele.damico@fitre.it, linux-kernel@vger.kernel.org
Subject: [patch] dont force uclinux mtd map to be root dev
Date: Fri, 13 Apr 2007 08:19:31 -0400	[thread overview]
Message-ID: <200704130819.32657.vapier@gentoo.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

the cheesy uclinux mtd maps can be used for more than just the root device, so 
i think we should drop the forcing.  also, i feel like this is a policy 
decision that shouldnt be in the kernel in the first place.  people who have 
been lazy and boot with uclinux mtd maps and dont put root= into their 
commandline can simply add the appropriate root= line either into their 
bootloader or into the compiled in bootargs

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
diff --git a/drivers/mtd/maps/uclinux.c b/drivers/mtd/maps/uclinux.c
index 389fea2..14ffb1a 100644
--- a/drivers/mtd/maps/uclinux.c
+++ b/drivers/mtd/maps/uclinux.c
@@ -16,7 +16,6 @@
 #include <linux/kernel.h>
 #include <linux/fs.h>
 #include <linux/major.h>
-#include <linux/root_dev.h>
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/map.h>
 #include <linux/mtd/partitions.h>
@@ -89,10 +88,6 @@ int __init uclinux_mtd_init(void)
 	uclinux_ram_mtdinfo = mtd;
 	add_mtd_partitions(mtd, uclinux_romfs, NUM_PARTITIONS);
 
-	printk("uclinux[mtd]: set %s to be root filesystem\n",
-	     	uclinux_romfs[0].name);
-	ROOT_DEV = MKDEV(MTD_BLOCK_MAJOR, 0);
-
 	return(0);
 }
 

[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]

             reply	other threads:[~2007-04-13 12:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-13 12:19 Mike Frysinger [this message]
2007-04-13 12:28 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704130819.32657.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=greg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michele.damico@fitre.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®