Re: make clean for DocBook

[Randy Dunlap <randy.dunlap@oracle.com>]

On Fri, 13 Apr 2007 21:32:50 +0200 Sam Ravnborg wrote:

> > > 
> > > 
> > > And we will visit DocBook with mrproper - but not clean.
> > > I have no stron opinion when to delete generated files in DocBook.
> > 
> > OK, that's fine, thanks for the info...
> > but trying 'make mrproper' gives me:
> > 
> > make -f scripts/Makefile.clean obj=Documentation/DocBook
> > make -f scripts/Makefile.clean obj=Documentation/DocBook/man/
> > make[2]: execvp: /bin/sh: Argument list too long
> > make[2]: *** [__clean] Error 127
> > make[1]: *** [Documentation/DocBook/man/] Error 2
> > make: *** [_mrproper_Documentation/DocBook] Error 2
> > 
> > DocBook/man/ contains about 2000 files.
> > Is there some way to have scripts/Makefile.clean just do
> > 	rm -rf Documentation/DocBook/man/
> > ?  or some other solution?
> 
> Something like this should do it.
> This deletes the man/ directory entirely so
> I have to do that when I check in the patch.
> 
> Let me know if this works for you.

Yes, thanks.

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>


> 	Sam
> 
> diff --git a/Documentation/DocBook/Makefile b/Documentation/DocBook/Makefile
> index 867608a..960f402 100644
> --- a/Documentation/DocBook/Makefile
> +++ b/Documentation/DocBook/Makefile
> @@ -152,6 +152,7 @@ quiet_cmd_db2man = MAN     $@
>  	@(which xmlto > /dev/null 2>&1) || \
>  	 (echo "*** You need to install xmlto ***"; \
>  	  exit 1)
> +	$(Q)mkdir -p $(obj)/man
>  	$(call cmd,db2man)
>  	@touch $@
>  
> @@ -212,11 +213,7 @@ clean-files := $(DOCBOOKS) \
>  	$(patsubst %.xml, %.9,    $(DOCBOOKS)) \
>  	$(C-procfs-example)
>  
> -clean-dirs := $(patsubst %.xml,%,$(DOCBOOKS))
> -
> -#man put files in man subdir - traverse down
> -subdir- := man/
> -
> +clean-dirs := $(patsubst %.xml,%,$(DOCBOOKS)) man
>  
>  # Declare the contents of the .PHONY variable as phony.  We keep that
>  # information in a variable se we can use it in if_changed and friends.
> diff --git a/Documentation/DocBook/man/Makefile b/Documentation/DocBook/man/Makefile
> deleted file mode 100644
> index 4fb7ea0..0000000
> --- a/Documentation/DocBook/man/Makefile
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -# Rules are put in Documentation/DocBook
> -
> -clean-files := *.9.gz *.sgml manpage.links manpage.refs
> 
> -

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***