From: Andrew Morton <akpm@linux-foundation.org>
To: steve.cameron@hp.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
jens.axboe@oracle.com, mike.miller@hp.com,
james.bottomley@steeleye.com
Subject: Re: [PATCH 1/1] cciss: include scsi/scsi.h unconditionally
Date: Fri, 13 Apr 2007 14:34:13 -0700 [thread overview]
Message-ID: <20070413143413.6b9ac0e7.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070413142312.GA24021@quandary.cca.cpqcorp.net>
On Fri, 13 Apr 2007 09:23:12 -0500
Stephen Cameron <steve.cameron@hp.com> wrote:
> Make cciss unconditionally include scsi/scsi.h
For what reason?
>
> From: Stephen M. Cameron <steve.cameron@hp.com>
> Signed-off-by: Stephen M. Cameron <steve.cameron@hp.com>
>
> ---
>
> drivers/block/cciss.c | 1 +
> drivers/block/cciss_scsi.c | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/block/cciss.c~include_scsi_h_unconditionally drivers/block/cciss.c
> --- linux-2.6.21-rc6/drivers/block/cciss.c~include_scsi_h_unconditionally 2007-04-13 08:23:07.000000000 -0500
> +++ linux-2.6.21-rc6-scameron/drivers/block/cciss.c 2007-04-13 08:25:05.000000000 -0500
> @@ -45,6 +45,7 @@
> #include <linux/blkdev.h>
> #include <linux/genhd.h>
> #include <linux/completion.h>
> +#include <scsi/scsi.h>
> #include <scsi/sg.h>
> #include <scsi/scsi_ioctl.h>
> #include <linux/cdrom.h>
> diff -puN drivers/block/cciss_scsi.c~include_scsi_h_unconditionally drivers/block/cciss_scsi.c
> --- linux-2.6.21-rc6/drivers/block/cciss_scsi.c~include_scsi_h_unconditionally 2007-04-13 08:23:53.000000000 -0500
> +++ linux-2.6.21-rc6-scameron/drivers/block/cciss_scsi.c 2007-04-13 08:24:34.000000000 -0500
> @@ -35,7 +35,6 @@
>
> #include <asm/atomic.h>
>
> -#include <scsi/scsi.h>
> #include <scsi/scsi_cmnd.h>
> #include <scsi/scsi_device.h>
> #include <scsi/scsi_host.h>
next prev parent reply other threads:[~2007-04-13 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-13 14:23 Stephen Cameron
2007-04-13 21:34 ` Andrew Morton [this message]
2007-04-13 22:48 ` Cameron, Steve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070413143413.6b9ac0e7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=james.bottomley@steeleye.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mike.miller@hp.com \
--cc=steve.cameron@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®