From: Duncan Sands <baldrick@free.fr>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usbatm_heavy_init: don't use CLONE_SIGHAND
Date: Sat, 14 Apr 2007 00:59:23 +0200 [thread overview]
Message-ID: <200704140059.23475.baldrick@free.fr> (raw)
In-Reply-To: <20070412235631.GA1050@tv-sign.ru>
On Friday 13 April 2007 01:56:31 Oleg Nesterov wrote:
> usbatm_do_heavy_init() calls allow_signal() which plays with parent process's
> ->sighand.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Duncan Sands <baldrick@free.fr>
> --- 2.6.21-rc5/drivers/usb/atm/usbatm.c~usbatm 2006-11-27 21:19:30.000000000 +0300
> +++ 2.6.21-rc5/drivers/usb/atm/usbatm.c 2007-04-13 03:34:56.000000000 +0400
> @@ -1019,7 +1019,7 @@ static int usbatm_do_heavy_init(void *ar
>
> static int usbatm_heavy_init(struct usbatm_data *instance)
> {
> - int ret = kernel_thread(usbatm_do_heavy_init, instance, CLONE_KERNEL);
> + int ret = kernel_thread(usbatm_do_heavy_init, instance, CLONE_FS | CLONE_FILES);
>
> if (ret < 0) {
> usb_err(instance, "%s: failed to create kernel_thread (%d)!\n", __func__, ret);
>
>
prev parent reply other threads:[~2007-04-13 22:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 23:56 Oleg Nesterov
2007-04-13 22:59 ` Duncan Sands [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704140059.23475.baldrick@free.fr \
--to=baldrick@free.fr \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®