From: Sam Ravnborg <sam@ravnborg.org>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Richard Henderson <rth@twiddle.net>,
Jay Estabrook <jay.estabrook@hp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALPHA: support graphics on non-zero PCI domains (take 2)
Date: Sun, 15 Apr 2007 14:30:20 +0200 [thread overview]
Message-ID: <20070415123020.GA19688@uranus.ravnborg.org> (raw)
In-Reply-To: <20070415152222.A12703@jurassic.park.msu.ru>
>
> > > +#ifndef CONFIG_ALPHA_GENERIC
> > > +EXPORT_SYMBOL(tsunami_ioportmap);
> > > +EXPORT_SYMBOL(tsunami_ioremap);
> > > +#endif
> >
> > It looks strange that the function is always defined but conditionally exported.
> > Also usual style is to place EXPORT right after closing brace of function -
> > (with no empty lines in-between).
>
> In a generic kernel the IO functions are never addressed directly,
> only via machine vector, so there is no point in exporting them.
> What about something like EXPORT_SYMBOL_NONGENERIC() macro?
As I wrote it looked strange. Unconditionally exporting them should not harm
and then we are one pair of ifdef/endif shorter?
Nitty gritty detail so do what you think match best.
Sam
next prev parent reply other threads:[~2007-04-15 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-15 7:19 Ivan Kokshaysky
2007-04-15 9:01 ` Sam Ravnborg
2007-04-15 11:22 ` Ivan Kokshaysky
2007-04-15 12:30 ` Sam Ravnborg [this message]
2007-04-15 21:26 ` Jay Estabrook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070415123020.GA19688@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jay.estabrook@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®