From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754064AbXDPLKk (ORCPT ); Mon, 16 Apr 2007 07:10:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030420AbXDPLKj (ORCPT ); Mon, 16 Apr 2007 07:10:39 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:36933 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030367AbXDPLKf (ORCPT ); Mon, 16 Apr 2007 07:10:35 -0400 Date: Mon, 16 Apr 2007 12:10:26 +0100 From: Christoph Hellwig To: Pavel Emelianov Cc: Christoph Hellwig , sct@redhat.com, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, Linux Kernel Mailing List , devel@openvz.org Subject: Re: [PATCH] Check for error returned by kthread_create on creating journal thread Message-ID: <20070416111026.GA22116@infradead.org> Mail-Followup-To: Christoph Hellwig , Pavel Emelianov , sct@redhat.com, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, Linux Kernel Mailing List , devel@openvz.org References: <4623289A.1000101@sw.ru> <20070416102107.GA12818@infradead.org> <462359B2.7070706@sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <462359B2.7070706@sw.ru> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 16, 2007 at 03:10:42PM +0400, Pavel Emelianov wrote: > Christoph Hellwig wrote: > > On Mon, Apr 16, 2007 at 11:41:14AM +0400, Pavel Emelianov wrote: > >> If the thread failed to create the subsequent wait_event > >> will hang forever. > >> > >> This is likely to happen if kernel hits max_threads limit. > >> > >> Will be critical for virtualization systems that limit the > >> number of tasks and kernel memory usage within the container. > > > >> --- ./fs/jbd/journal.c.jbdthreads 2007-04-16 11:17:36.000000000 +0400 > >> +++ ./fs/jbd/journal.c 2007-04-16 11:30:09.000000000 +0400 > >> @@ -211,10 +211,16 @@ end_loop: > >> return 0; > >> } > >> > >> -static void journal_start_thread(journal_t *journal) > >> +static int journal_start_thread(journal_t *journal) > >> { > >> - kthread_run(kjournald, journal, "kjournald"); > >> + struct task_struct *t; > >> + > >> + t = kthread_run(kjournald, journal, "kjournald"); > >> + if (IS_ERR(t)) > >> + return PTR_ERR(t); > >> + > >> wait_event(journal->j_wait_done_commit, journal->j_task != 0); > > > > Note that this wait_event should exist at all, and the return > > Should NOT you mean? Umm, yes - of course :) > > value of kthread_run should be assigned to journal->j_task. Also > > the code doesn't use the kthread primitives in other places leading > > to crufty code. > > Well, this could be done with a separate patch, I think.