From: David Miller <davem@davemloft.net>
To: xemul@sw.ru
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH] Set a separate lockdep class for neighbour table's proxy_queue
Date: Tue, 17 Apr 2007 12:46:10 -0700 (PDT) [thread overview]
Message-ID: <20070417.124610.63508619.davem@davemloft.net> (raw)
In-Reply-To: <46236739.5000409@sw.ru>
From: Pavel Emelianov <xemul@sw.ru>
Date: Mon, 16 Apr 2007 16:08:25 +0400
> Otherwise the following calltrace will lead to a wrong
> lockdep warning:
>
> neigh_proxy_process()
> `- lock(neigh_table->proxy_queue.lock);
> arp_redo /* via tbl->proxy_redo */
> arp_process
> neigh_event_ns
> neigh_update
> skb_queue_purge
> `- lock(neighbor->arp_queue.lock);
>
> This is not a deadlock actually, as neighbor table's proxy_queue
> and the neighbor's arp_queue are different queues.
>
> Lockdep thinks there is a deadlock as both queues are initialized
> with skb_queue_head_init() and thus have a common class.
Patch applied, thank you.
Please provide a proper "Signed-off-by: " line in future patch
submissions or else I will ignore your patches entirely.
Thanks!
next prev parent reply other threads:[~2007-04-17 19:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-16 12:08 Pavel Emelianov
2007-04-17 19:46 ` David Miller [this message]
2007-04-19 13:02 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070417.124610.63508619.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome