mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Greg KH <greg@kroah.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	Tejun Heo <htejun@gmail.com>,
	Markus Rechberger <markus.rechberger@amd.com>,
	USB development list <linux-usb-devel@lists.sourceforge.net>,
	Kernel development list <linux-kernel@vger.kernel.org>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Swen Schillig <swen@vnet.ibm.com>
Subject: Re: [linux-usb-devel] How should an exit routine wait for release() callbacks?
Date: Tue, 17 Apr 2007 09:26:15 +0200	[thread overview]
Message-ID: <20070417092615.7381a5f3@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20070416221247.GA9365@kroah.com>

On Mon, 16 Apr 2007 15:12:47 -0700,
Greg KH <greg@kroah.com> wrote:

> Ah, just found this original thread, now Cornelia's patches make more
> sense...

I would have included a pointer, but couldn't access marc yesterday
evening, sorry...

> 
> On Fri, Apr 13, 2007 at 11:24:58AM -0400, Alan Stern wrote:
> > Tejun, it just occurred to me that you would be interested in this email 
> > thread.  Just to bring you up to speed, here's the original question:
> > 
> > > I've got a module which registers a struct device.  (It represents a
> > > virtual device, not a real one, but that doesn't matter.)
> 
> Wait, that's the issue right there.
> 
> Don't do that.
> 
> devices should be created by busses or the platform core, which owns the
> release function for them.  Individual drivers should not create
> devices.

There are drivers that do it, for a variety of reasons.

> 
> Hm, but then, how would you ever unload a bus, as the same issue might
> be there too...

Exactly :) This would imply busses/subsystems could never be unloadable
modules.

> 
> Any specific code in the kernel you can point to that has this issue
> today?

zfcp comes to mind. They register some units in zfcp_aux.c, which don't
have anything to do with the bus the zfcp adapter is on (the ccw bus).
Currently, that is "solved" by disallowing zfcp module unloading.

  reply	other threads:[~2007-04-17  7:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-12 21:23 Alan Stern
2007-04-13  9:03 ` Cornelia Huck
2007-04-13 11:42   ` Markus Rechberger
2007-04-13 13:24     ` Cornelia Huck
2007-04-13 14:15       ` Markus Rechberger
2007-04-13 14:27         ` Cornelia Huck
2007-04-13 15:24           ` Alan Stern
2007-04-16  8:53             ` Cornelia Huck
2007-04-16 14:43               ` Alan Stern
2007-04-16 14:51                 ` [linux-usb-devel] " Robert Marquardt
2007-04-16 15:05                 ` Cornelia Huck
2007-04-16 22:12             ` [linux-usb-devel] " Greg KH
2007-04-17  7:26               ` Cornelia Huck [this message]
2007-04-17 15:59               ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070417092615.7381a5f3@gondolin.boeblingen.de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=greg@kroah.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=htejun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=markus.rechberger@amd.com \
    --cc=stern@rowland.harvard.edu \
    --cc=swen@vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®