From: Matt Mackall <mpm@selenic.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@linux-foundation.com, linux-kernel@vger.kernel.org
Subject: Re: slab allocators: Remove obsolete SLAB_MUST_HWCACHE_ALIGN
Date: Tue, 17 Apr 2007 18:09:55 -0500 [thread overview]
Message-ID: <20070417230955.GG11166@waste.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0704162232530.31027@schroedinger.engr.sgi.com>
On Mon, Apr 16, 2007 at 10:35:21PM -0700, Christoph Lameter wrote:
> The flag SLAB_MUST_HWCACHE_ALIGN is
>
> 1. Never checked by SLAB at all.
>
> 2. A duplicate of SLAB_HWCACHE_ALIGN for SLUB
>
> 3. Fulfills the role of SLAB_HWCACHE_ALIGN for SLOB.
>
> The only remaining use is in sparc64 and ppc64 and their use there
> reflects some earlier role that the slab flag once may have had. If
> its specified then SLAB_HWCACHE_ALIGN is also specified.
>
> The flag is confusing, inconsistent and has no purpose.
>
> Remove it.
Hmm, at one point this was needed by SLOB to boot on x86, I wonder
when that changed? But if SLAB is using the other define now, I'm
happy to switch.
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Matt Mackall <mpm@selenic.com>
--
Mathematics is the supreme nostalgia of our time.
prev parent reply other threads:[~2007-04-17 23:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 5:35 Christoph Lameter
2007-04-17 7:31 ` Pekka Enberg
2007-04-17 23:09 ` Matt Mackall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070417230955.GG11166@waste.org \
--to=mpm@selenic.com \
--cc=akpm@linux-foundation.com \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®