From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1031192AbXDSHdV@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1031192AbXDSHdV (ORCPT <rfc822;w@1wt.eu>);
	Thu, 19 Apr 2007 03:33:21 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1031161AbXDSHdU
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 19 Apr 2007 03:33:20 -0400
Received: from smtp-104-thursday.nerim.net ([62.4.16.104]:2170 "EHLO
	kraid.nerim.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1031192AbXDSHdT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 19 Apr 2007 03:33:19 -0400
Date: Thu, 19 Apr 2007 09:33:27 +0200
From: Jean Delvare <khali@linux-fr.org>
To: Milind Arun Choudhary <milindchoudhary@gmail.com>
Cc: Kernel Janitors <kernel-janitors@lists.osdl.org>, i2c <i2c@lm-sensors.org>,
       Andrw Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [KJ][PATCH] i2c: SPIN_LOCK_UNLOCKED cleanup
Message-ID: <20070419093327.7112d515@hyperion.delvare>
In-Reply-To: <20070419040557.GA14283@arun.site>
References: <20070419040557.GA14283@arun.site>
X-Mailer: Sylpheed-Claws 2.5.5 (GTK+ 2.10.6; x86_64-suse-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 19 Apr 2007 09:35:58 +0530, Milind Arun Choudhary wrote:
> SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead 
> 
> Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
> 
> ---
>  i2c-pxa.c     |    2 +-
>  i2c-s3c2410.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
> index 14e83d0..d5d44ed 100644
> --- a/drivers/i2c/busses/i2c-pxa.c
> +++ b/drivers/i2c/busses/i2c-pxa.c
> @@ -825,7 +825,7 @@ static const struct i2c_algorithm i2c_pxa_algorithm = {
>  };
>  
>  static struct pxa_i2c i2c_pxa = {
> -	.lock	= SPIN_LOCK_UNLOCKED,
> +	.lock	= __SPIN_LOCK_UNLOCKED(i2c_pxa.lock),
>  	.adap	= {
>  		.owner		= THIS_MODULE,
>  		.algo		= &i2c_pxa_algorithm,
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index 556f244..3eb5958 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -570,7 +570,7 @@ static const struct i2c_algorithm s3c24xx_i2c_algorithm = {
>  };
>  
>  static struct s3c24xx_i2c s3c24xx_i2c = {
> -	.lock	= SPIN_LOCK_UNLOCKED,
> +	.lock	= __SPIN_LOCK_UNLOCKED(s3c24xx_i2c.lock),
>  	.wait	= __WAIT_QUEUE_HEAD_INITIALIZER(s3c24xx_i2c.wait),
>  	.adap	= {
>  		.name			= "s3c2410-i2c",
> 

Applied, thanks.

-- 
Jean Delvare