From: David Chinner <dgc@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jarek Poplawski <jarkao2@o2.pl>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] workqueue: debug possible endless loop in cancel_rearming_delayed_work
Date: Fri, 20 Apr 2007 00:48:44 +1000 [thread overview]
Message-ID: <20070419144844.GH32602149@melbourne.sgi.com> (raw)
In-Reply-To: <20070419073222.GA438@elte.hu>
On Thu, Apr 19, 2007 at 09:32:22AM +0200, Ingo Molnar wrote:
>
> * Jarek Poplawski <jarkao2@o2.pl> wrote:
>
> > + int i = 1000;
> >
> > - while (!cancel_delayed_work(dwork))
> > + while (!cancel_delayed_work(dwork)) {
> > flush_workqueue(wq);
> > + BUG_ON(!i--);
> > + }
>
> if then make it a WARN_ON(). But ... dont we have the softlockup
> detector for such cases? Does CONFIG_DETECT_SOFTLOCKUP=y give you enough
> information?
No, you won't get a soft lockup - flush_workqueue() has a
schedule() call in the middle of it.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-04-19 14:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 6:54 Jarek Poplawski
2007-04-19 7:32 ` Ingo Molnar
2007-04-19 8:28 ` Jarek Poplawski
2007-04-19 14:48 ` David Chinner [this message]
2007-04-19 14:46 ` David Chinner
2007-04-20 8:13 ` Jarek Poplawski
2007-04-20 8:53 ` David Chinner
2007-04-20 10:21 ` Jarek Poplawski
2007-04-20 11:01 ` David Chinner
2007-04-20 12:12 ` [PATCH] workqueue: cancel_rearming_delayed_work/workqueue usage warning Jarek Poplawski
2007-04-20 17:23 ` Oleg Nesterov
2007-04-23 9:41 ` Jarek Poplawski
2007-04-19 17:07 ` [PATCH -mm] workqueue: debug possible endless loop in cancel_rearming_delayed_work Chuck Ebbert
2007-04-20 7:14 ` Jarek Poplawski
2007-04-20 11:09 Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070419144844.GH32602149@melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=jarkao2@o2.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome