From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965153AbXDSU7o (ORCPT ); Thu, 19 Apr 2007 16:59:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965345AbXDSU7o (ORCPT ); Thu, 19 Apr 2007 16:59:44 -0400 Received: from caffeine.uwaterloo.ca ([129.97.134.17]:36759 "EHLO caffeine.csclub.uwaterloo.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965153AbXDSU7n (ORCPT ); Thu, 19 Apr 2007 16:59:43 -0400 Date: Thu, 19 Apr 2007 16:59:42 -0400 To: Jean Delvare Cc: Haavard Skinnemoen , David Brownell , Bryan Wu , Andrew Morton , Deepak Saxena , linux-kernel@vger.kernel.org, Christer Weinigel , Jordan Crouse Subject: Re: [PATCH v3] Bitbanging i2c bus driver using the GPIO API Message-ID: <20070419205942.GC5577@csclub.uwaterloo.ca> References: <11765554074106-git-send-email-hskinnemoen@atmel.com> <20070414163418.20490fe2@dhcp-252-105.norway.atmel.com> <20070414192807.60bdf84b@hyperion.delvare> <20070418174256.GB5577@csclub.uwaterloo.ca> <20070419085413.1520feef@hyperion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070419085413.1520feef@hyperion.delvare> User-Agent: Mutt/1.5.13 (2006-08-11) From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 19, 2007 at 08:54:13AM +0200, Jean Delvare wrote: > The major difference is that the implementation in scx200_i2c is > hardware-specific, while the i2c-gpio driver is a generic one, so it's > a lot better. > > What this means is that i2c-gpio obsoletes scx200_i2c, so I am inclined > to delete scx200_i2c right away. I'm not even sure anyone still uses it > now that scx200_acb has been fixed and is reported to work very well. > If anyone really needs to do I2C over GPIO pins on SCx200, this should > be reimplemented on top of i2c-gpio. I use scx200_i2c. The SBC I am using doesn't work with the scx200_acb (different pins on the cpu after all). I would love to see it reimplemented using the generic interface, since there isn't that many lines of code involved as far as I can tell. Well scx200_acb works fine on a Geode LX board, but not on a Geode SC1200 board. Unless it has been fixed since 2.6.18, then it still doesn't work, but scx200_i2c works perfectly fine. > It also looks to me like i2c-ixp2000 and i2c-ixp4xx are obsoleted by > i2c-gpio. Deepak, can you please try using i2c-gpio instead and confirm > that i2c-ixp2000 and i2c-ixp4xx can be deleted? -- Len Sorensen