From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 10/11] Char: cyclades, clear interrupts before releasing
Date: Thu, 19 Apr 2007 21:51:46 -0700 [thread overview]
Message-ID: <20070419215146.1b85353c.akpm@linux-foundation.org> (raw)
In-Reply-To: <4488267294095310@karneval.cz>
On Wed, 18 Apr 2007 12:07:56 +0200 (CEST) Jiri Slaby <jirislaby@gmail.com> wrote:
> + /* non-Z with old PLX */
> + if (cinfo->num_chips != -1 && (readb(cinfo->base_addr + CyPLX_VER) &
> + 0x0f) == PLX_9050)
> + cy_writeb(cinfo->ctl_addr + 0x4c, 0);
> + else
> +#ifndef CONFIG_CYZ_INTR
> + if (cinfo->num_chips != -1)
> +#endif
> + cy_writew(cinfo->ctl_addr + 0x68,
> + readw(cinfo->ctl_addr + 0x68) & ~0x0900);
well that a bit nasty.
We already have that IS_CYC_Z() thing. Perhaps we could turn that into a nice
lowercase-named C function and provide a CONFIG_CYZ_INTR=y version which
does `return 1'. Or something like that.
But the above is, umm, inconsistent with the cleanups you've been doing ;)
next prev parent reply other threads:[~2007-04-20 4:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-18 10:03 [PATCH 1/11] Char: cyclades, create cy_init_Ze Jiri Slaby
2007-04-18 10:03 ` [PATCH 2/11] Char: cyclades, use pci_iomap/unmap Jiri Slaby
2007-04-18 10:04 ` [PATCH 3/11] Char: cyclades, init Ze immediately Jiri Slaby
2007-04-18 10:04 ` [PATCH 4/11] Char: cyclades, create cy_pci_probe Jiri Slaby
2007-04-18 10:05 ` [PATCH 5/11] Char: cyclades, move card entries init into function Jiri Slaby
2007-04-18 10:05 ` [PATCH 6/11] Char: cyclades, init card struct immediately Jiri Slaby
2007-04-18 10:06 ` [PATCH 7/11] Char: cyclades, remove some global vars Jiri Slaby
2007-04-18 10:06 ` [PATCH 8/11] Char: cyclades, cy_init error handling Jiri Slaby
2007-04-18 10:07 ` [PATCH 9/11] Char: cyclades, tty_register_device separately for each device Jiri Slaby
2007-04-18 10:07 ` [PATCH 10/11] Char: cyclades, clear interrupts before releasing Jiri Slaby
2007-04-20 4:51 ` Andrew Morton [this message]
2007-04-18 10:08 ` [PATCH 11/11] Char: cyclades, allow DEBUG_SHIRQ Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070419215146.1b85353c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome