mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Matt Mackall <mpm@selenic.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Keiichi KII <k-keiichi@bx.jp.nec.com>,
	davem@davemloft.net, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [RFC][PATCH -mm take4 2/6] support multiple logging
Date: Fri, 20 Apr 2007 12:00:36 -0700	[thread overview]
Message-ID: <20070420120036.2a96cf8d@dxpl.pdx.osdl.net> (raw)
In-Reply-To: <20070420182109.GR11115@waste.org>

On Fri, 20 Apr 2007 13:21:10 -0500
Matt Mackall <mpm@selenic.com> wrote:

> On Fri, Apr 20, 2007 at 11:15:26AM -0700, Andrew Morton wrote:
> > On Fri, 20 Apr 2007 18:51:13 +0900
> > Keiichi KII <k-keiichi@bx.jp.nec.com> wrote:
> > 
> > > > I started to do some cleanups and fixups here, but abandoned it when it was
> > > > all getting a bit large.
> > > > 
> > > > Here are some fixes against this patch:
> > > 
> > > I'm going to fix my patches by following your reviews and send new patches 
> > > on the LKML and the netdev ML in a few days.
> > > 
> > 
> > Well..  before you can finish this work we need to decide upon what the
> > interface to userspace will be.
> > 
> > - The miscdev isn't appropriate
> > 
> > - netlink remains a possibility
> > 
> > - Stephen suggests an ioctl against a socket and davem suggests socket
> >   options, but it's unclear to me how that socket will get bound to
> >   netconsole?
> 
> Yeah, that's a bit of a head-scratcher.
> 
> > either way, I agree with the overall thrust of this work: netconsole is
> > useful in production environments, can become more useful and will need
> > runtime configurability.
> > 
> > 
> > I wonder if we're approaching this in the right way, however...
> > 
> > At a high level, netconsole is just a flow of UDP packets between two
> > machines.  The kernel already has rich and well-understood ways of creating
> > and configuring such flows.
> > 
> > So...  instead of creating a brand new way of configuring such a flow via
> > sysfs and ioctl, could we instead create a flow using the existing
> > mechanisms (presumably the socket API) and then "transfer" the information
> > from that flow over to netconsole by some means??
> 
> We don't really have anything that corresponds to netpoll's
> connections at higher levels.
> 
> I'm tempted to say we should make this work more like the dummy
> network device. ie:
> 
> modprobe netconsole -o netcon1 [params]
> modprobe netconsole -o netcon2 [params]

The configuration of netconsole's looks like the configuration of routes.
Granted you probably have more routes than netconsoles, but the interface
issues are similar.  Netlink with a small application wouldn't be nice.
And having /proc/net/netconsole (read-only) would be good for the netlink
impaired.

  reply	other threads:[~2007-04-20 19:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <462605DC.2080804@bx.jp.nec.com>
2007-04-18 12:05 ` [RFC][PATCH -mm take4 1/6] marking __init Keiichi KII
2007-04-18 12:06 ` [RFC][PATCH -mm take4 2/6] support multiple logging Keiichi KII
2007-04-18 14:40   ` Stephen Hemminger
2007-04-20  9:58     ` Keiichi KII
2007-04-20  4:08   ` Andrew Morton
2007-04-20  9:51     ` Keiichi KII
2007-04-20 18:15       ` Andrew Morton
2007-04-20 18:21         ` Matt Mackall
2007-04-20 19:00           ` Stephen Hemminger [this message]
2007-04-24  8:14             ` Keiichi KII
2007-04-24  8:14         ` Keiichi KII
2007-04-24  8:29           ` Andrew Morton
2007-04-24 15:21             ` Stephen Hemminger
2007-04-26  4:02               ` Keiichi KII
2007-04-26  4:45                 ` David Miller
2007-04-18 12:08 ` [RFC][PATCH -mm take4 3/6] add interface for netconsole using sysfs Keiichi KII
2007-04-20  4:06   ` Andrew Morton
2007-04-18 12:11 ` [RFC][PATCH -mm take4 4/6] using symlink for the net_device Keiichi KII
2007-04-20  4:12   ` Andrew Morton
2007-04-18 12:12 ` [RFC][PATCH -mm take4 5/6] switch function of netpoll Keiichi KII
2007-04-18 12:14 ` [RFC][PATCH -mm take4 6/6] add ioctls for adding/removing target Keiichi KII
2007-04-20  4:16   ` Andrew Morton
2007-04-20  5:39     ` Stephen Hemminger
2007-04-20  6:59       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070420120036.2a96cf8d@dxpl.pdx.osdl.net \
    --to=shemminger@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=k-keiichi@bx.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome