From: Benjamin LaHaise <bcrl@kvack.org>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>,
Christoph Lameter <clameter@sgi.com>,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
Larry Woodman <lwoodman@redhat.com>
Subject: Re: [PATCH] Make new setting of panic_on_oom
Date: Fri, 20 Apr 2007 08:41:57 -0400 [thread overview]
Message-ID: <20070420124157.GA21709@kvack.org> (raw)
In-Reply-To: <20070420202752.0E69.Y-GOTO@jp.fujitsu.com>
On Fri, Apr 20, 2007 at 08:43:56PM +0900, Yasunori Goto wrote:
>
> The current panic_on_oom may not work if there is a process using
> cpusets/mempolicy, because other nodes' memory may still free.
> But some people want failover by panic ASAP even if they are used.
> This patch makes new setting for its request.
>
> This is not tested yet. But it would work.
> read_lock(&tasklist_lock);
>
> + if (sysctl_panic_on_oom == 2)
> + panic("out of memory. Compulsory panic_on_oom is selected.\n");
> +
Wouldn't it be safer to put the panic before the read_lock()?
-ben
--
"Time is of no importance, Mr. President, only life is important."
Don't Email: <zyntrop@kvack.org>.
next prev parent reply other threads:[~2007-04-20 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-20 11:43 Yasunori Goto
2007-04-20 12:41 ` Benjamin LaHaise [this message]
2007-04-20 16:16 ` Christoph Lameter
2007-04-21 4:28 ` Yasunori Goto
2007-04-21 15:27 ` Benjamin LaHaise
2007-04-24 5:14 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070420124157.GA21709@kvack.org \
--to=bcrl@kvack.org \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lwoodman@redhat.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome