mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Kemper <sebastian_ml@gmx.net>
To: linux-kernel@vger.kernel.org
Cc: dbrownell@users.sourceforge.net
Subject: No proper shutdown after kernel 2.6.13-rc2
Date: Sun, 22 Apr 2007 10:08:16 +0200	[thread overview]
Message-ID: <200704221008.16946.sebastian_ml@gmx.net> (raw)

Hello list,

this is an old issue, I reported it to 
http://bugzilla.kernel.org/show_bug.cgi?id=5410 in 2005, but it still 
bothers me. My mouse light (simple Logitech USB mouse) still stays on 
after shutdown with 2.6.21-rc7.

But, headway has been made (a little). It turned out that I don't have a 
jumper on my motherboard that would explain this behaviour (e.g. 
PS2_USB_PWR). Then there's MS Windows which manages to shut off the 
mouse light when it shuts down.

Last but not least I finally managed to find the commit which triggered 
the issue back in 2.6.13-rc2: 

commit edfd6aee1f073ae645bd3e60ef96090fc9f0957b
Author: david-b@pacbell.net <david-b@pacbell.net>
Date:   Wed Jun 29 07:03:10 2005 -0700

    [PATCH] USB: fix ohci merge glitch

    A patch re-organizing some parts of root hub initialization deleted 
the
    code initializing the bus-neutral reboot/shutdown notifier for OHCI.
    This patch just restores that deleted code.

    Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
index 0375097..68decab 100644
--- a/drivers/usb/host/ohci-hcd.c
+++ b/drivers/usb/host/ohci-hcd.c
@@ -673,8 +673,10 @@ retry:

        ohci_dump (ohci, 1);

-       if (ohci_to_hcd(ohci)->self.root_hub == NULL)
+       if (ohci_to_hcd(ohci)->self.root_hub == NULL) {
+               register_reboot_notifier (&ohci->reboot_notifier);
                create_debug_files (ohci);
+       }

        return 0;
 }

I'd really appreciate if someone could attend to this.

Thanks!

Regards
Sebastian

                 reply	other threads:[~2007-04-22  8:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704221008.16946.sebastian_ml@gmx.net \
    --to=sebastian_ml@gmx.net \
    --cc=dbrownell@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®