From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030788AbXDVTkH (ORCPT ); Sun, 22 Apr 2007 15:40:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030811AbXDVTkH (ORCPT ); Sun, 22 Apr 2007 15:40:07 -0400 Received: from pasmtpb.tele.dk ([80.160.77.98]:44621 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030788AbXDVTkG (ORCPT ); Sun, 22 Apr 2007 15:40:06 -0400 Date: Sun, 22 Apr 2007 21:40:56 +0200 From: Sam Ravnborg To: Mikael Starvik Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH 2.6.20 1/14] CRIS architecture update - Build system Message-ID: <20070422194056.GA17258@uranus.ravnborg.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 22, 2007 at 09:24:34PM +0200, Mikael Starvik wrote: > The attached patch improves the CRIS build system by allowing out-of-tree objdir everywhere I have browsed through the changes and this is in addition a much more readable set of Makefile's - good work! I stumbled over this: +AFLAGS = -traditional +LD = gcc-cris -mlinux -nostdlib +LDFLAGS = -T $(obj)/rescue.ld We have in i386 / x86_64 recently managed to get rid of -traditional. And it looks a bit strange that you use gcc as linker. But thats how it was also done before so not a big issue. > > Signed-off-by: Mikael Starvik Acked-by: Sam Ravnborg Sam