From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753354AbXDWXTe (ORCPT ); Mon, 23 Apr 2007 19:19:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754466AbXDWXTe (ORCPT ); Mon, 23 Apr 2007 19:19:34 -0400 Received: from mail.screens.ru ([213.234.233.54]:33127 "EHLO mail.screens.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753354AbXDWXTd (ORCPT ); Mon, 23 Apr 2007 19:19:33 -0400 Date: Tue, 24 Apr 2007 03:19:26 +0400 From: Oleg Nesterov To: "Rafael J. Wysocki" Cc: Andrew Morton , Ingo Molnar , ego@in.ibm.com, linux-kernel@vger.kernel.org, vatsa@in.ibm.com, paulmck@us.ibm.com, pavel@ucw.cz Subject: Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags Message-ID: <20070423231926.GA684@tv-sign.ru> References: <20070419120131.GB13435@in.ibm.com> <200704240040.18312.rjw@sisk.pl> <20070423225535.GB659@tv-sign.ru> <200704240110.35770.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200704240110.35770.rjw@sisk.pl> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 04/24, Rafael J. Wysocki wrote: > > On Tuesday, 24 April 2007 00:55, Oleg Nesterov wrote: > > On 04/24, Rafael J. Wysocki wrote: > > > > > > Should I clear it in dup_task_struct() or is there a better place? > > > > I personally think we should do this in dup_task_struct(). In fact, I believe > > it is better to replace the > > > > *tsk = *orig; > > > > with some helper (like setup_thread_stack() below), and that helper clears > > ->freezer_flags. Say, copy_task_struct(). > > Hmm, wouldn't that be overkill? copy_task_struct() would have to do > *tsk = *orig anyway, and we only need to clear one field apart from this. > > Some other fields are cleared towards the end of dup_task_struct(), so perhaps > we could clear freezer_flags in there too? Yes. And I strongly believe it is bad we don't have the helper which does some random stuf like "p->did_exec = 0". The same for thread_info. Could you answer quickly where do we clear TIF_FREEZE currently? We don't. Oleg.