From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754460AbXDWXGf (ORCPT ); Mon, 23 Apr 2007 19:06:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754466AbXDWXGf (ORCPT ); Mon, 23 Apr 2007 19:06:35 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:35028 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754460AbXDWXGe (ORCPT ); Mon, 23 Apr 2007 19:06:34 -0400 From: "Rafael J. Wysocki" To: Oleg Nesterov Subject: Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags Date: Tue, 24 Apr 2007 01:10:34 +0200 User-Agent: KMail/1.9.5 Cc: Andrew Morton , Ingo Molnar , ego@in.ibm.com, linux-kernel@vger.kernel.org, vatsa@in.ibm.com, paulmck@us.ibm.com, pavel@ucw.cz References: <20070419120131.GB13435@in.ibm.com> <200704240040.18312.rjw@sisk.pl> <20070423225535.GB659@tv-sign.ru> In-Reply-To: <20070423225535.GB659@tv-sign.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200704240110.35770.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, 24 April 2007 00:55, Oleg Nesterov wrote: > On 04/24, Rafael J. Wysocki wrote: > > > > Should I clear it in dup_task_struct() or is there a better place? > > I personally think we should do this in dup_task_struct(). In fact, I believe > it is better to replace the > > *tsk = *orig; > > with some helper (like setup_thread_stack() below), and that helper clears > ->freezer_flags. Say, copy_task_struct(). Hmm, wouldn't that be overkill? copy_task_struct() would have to do *tsk = *orig anyway, and we only need to clear one field apart from this. Some other fields are cleared towards the end of dup_task_struct(), so perhaps we could clear freezer_flags in there too? Rafael