mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Miles Lane <miles.lane@gmail.com>, Andrew Morton <akpm@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sysfs: use different lockdep subclass for s_active deactivation
Date: Thu, 26 Apr 2007 08:22:21 -0700	[thread overview]
Message-ID: <20070426152221.GB16563@kroah.com> (raw)
In-Reply-To: <20070426145047.GF17130@htj.dyndns.org>

On Thu, Apr 26, 2007 at 11:50:47PM +0900, Tejun Heo wrote:
> A sysfs node can delete other sysfs files when accessed.  This results
> in recursive s_active locking - read lock for file access, down lock
> of the vicitim for deactivation.  Tell lockdep that it's okay.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Miles, please test this patch.  It should remove the lockdep warning.
> Fixes for the other two problems will soon follow.
> 
> Greg, Andrew, after all the fixes are verified, I'll merge the fixes
> into the original patches and resend all the sysfs updates in better
> shape.  Sorry about all the trouble.

Thanks, that will make it easier for me, as I've seen a lot of them go
floating by recently :)

greg k-h

  reply	other threads:[~2007-04-26 15:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-25  5:15 2.6.21-rc7-mm1 + sysfs-oops-workaround.patch -- INFO: possible recursive locking detected Miles Lane
2007-04-25  5:18 ` Tejun Heo
2007-04-25 14:48   ` Antonino A. Daplas
2007-04-25 23:45     ` Nonfunctional ethernet (was Re: 2.6.21-rc7-mm1 + sysfs-oops-workaround.patch -- INFO: possible recursive locking detected) Antonino A. Daplas
2007-04-26  1:02       ` Antonino A. Daplas
2007-04-26  1:13         ` Andrew Morton
2007-04-26  2:26           ` Tejun Heo
2007-04-26  2:53             ` Andrew Morton
2007-04-26 14:50   ` [PATCH] sysfs: use different lockdep subclass for s_active deactivation Tejun Heo
2007-04-26 15:22     ` Greg KH [this message]
2007-04-26 17:21     ` Miles Lane
2007-04-26 17:33       ` Tejun Heo
2007-04-26 18:51         ` Miles Lane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070426152221.GB16563@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=htejun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miles.lane@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®