From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: Driver core: warn when userspace writes to the uevent file in a non-supported way
Date: Fri, 27 Apr 2007 22:41:04 +0100 [thread overview]
Message-ID: <20070427224104.386d8eab@the-village.bc.nu> (raw)
In-Reply-To: <200704272059.l3RKxUYn024215@hera.kernel.org>
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -296,6 +296,9 @@ out:
> static ssize_t store_uevent(struct device *dev, struct device_attribute *attr,
> const char *buf, size_t count)
> {
> + if (memcmp(buf, "add", 3) != 0)
> + dev_err(dev, "uevent: unsupported action-string; this will "
> + "be ignored in a future kernel version");
> kobject_uevent(&dev->kobj, KOBJ_ADD);
> return count;
> }
And checking for "add" without actually checking if count >= 3 is very
ugly style indeed. Not afaict any kind of security risk as the next 3
bytes are always going to be readable
prev parent reply other threads:[~2007-04-27 21:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200704272059.l3RKxUYn024215@hera.kernel.org>
2007-04-27 21:34 ` Alan Cox
2007-04-27 21:41 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070427224104.386d8eab@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®