From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lenb@kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [-mm patch] make drivers/misc/thinkpad_acpi:fan_mutex static
Date: Sun, 29 Apr 2007 01:09:53 -0300 [thread overview]
Message-ID: <20070429040953.GA29832@khazad-dum.debian.net> (raw)
In-Reply-To: <20070429025008.GK3468@stusta.de>
On Sun, 29 Apr 2007, Adrian Bunk wrote:
> Forward declarations of static functions (if required) and actual
> variables (like fan_mutex) belong into the C file, not the header.
Very well. I will fix the mess for 2.6.23, or, time permitting, 2.6.22.
> > Maybe I should just break the driver into multiple files in a subdirectory?
> > That would certainly make it *much* cleaner...
>
> But even more in this case, you will not want to have actual variables
> or prototypes of static functions in the header file.
I would not have to, in that case. The driver would be much easier to
write, and I will need to break it in two for an alsa module anyway, might
as well break it in one subdriver per file.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2007-04-29 4:10 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 5:57 2.6.21-rc7-mm2 Andrew Morton
2007-04-26 11:47 ` 2.6.21-rc7-mm2 Gabriel C
2007-04-26 20:37 ` 2.6.21-rc7-mm2 Andrew Morton
2007-04-26 20:46 ` 2.6.21-rc7-mm2 Randy Dunlap
2007-04-29 8:05 ` 2.6.21-rc7-mm2 Geert Uytterhoeven
2007-04-26 20:57 ` 2.6.21-rc7-mm2 Timur Tabi
2007-04-26 21:13 ` 2.6.21-rc7-mm2 Gabriel C
2007-04-26 21:33 ` 2.6.21-rc7-mm2 Andrew Morton
2007-04-26 12:16 ` 2.6.21-rc7-mm2 -- x86_64 VDSO compile error Andy Whitcroft
2007-04-26 13:27 ` Mel Gorman
2007-04-26 14:11 ` Andi Kleen
2007-04-26 14:31 ` Mel Gorman
2007-04-26 14:13 ` 2.6.21-rc7-mm2 -- x86_64 VDSO compile error II Andi Kleen
2007-04-26 14:39 ` Mel Gorman
2007-04-26 15:20 ` Mel Gorman
2007-04-26 15:24 ` Andi Kleen
2007-04-26 15:45 ` Mel Gorman
2007-04-27 0:39 ` Andi Kleen
2007-04-27 8:59 ` Mel Gorman
2007-04-27 15:50 ` [PATCH] Add vDSO for x86-64 with gettimeofday/clock_gettime/getcpu fix Mel Gorman
2007-04-27 16:34 ` Andi Kleen
2007-04-27 16:49 ` Mel Gorman
2007-04-26 12:30 ` 2.6.21-rc7-mm2 -- x86_64 blade hard hangs Andy Whitcroft
2007-04-26 13:51 ` Andi Kleen
2007-04-26 13:33 ` Mel Gorman
2007-04-26 14:46 ` Mel Gorman
2007-04-26 17:40 ` Mel Gorman
[not found] ` <20070426234002.GH5475@linux-os.sc.intel.com>
[not found] ` <20070427110709.GE3645@skynet.ie>
2007-04-27 17:54 ` Siddha, Suresh B
2007-04-27 23:59 ` Mel Gorman
2007-04-26 13:17 ` 2.6.21-rc7-mm2 Andy Whitcroft
2007-04-26 13:41 ` 2.6.21-rc7-mm2 -- PPC link failure Andy Whitcroft
2007-04-26 18:14 ` Andy Whitcroft
2007-04-26 18:27 ` Christoph Lameter
2007-04-26 18:40 ` Andy Whitcroft
2007-04-26 18:49 ` Christoph Lameter
2007-04-26 19:12 ` Christoph Lameter
2007-04-26 19:48 ` Andy Whitcroft
2007-04-26 20:23 ` Christoph Lameter
2007-04-27 16:55 ` Andy Whitcroft
2007-04-27 16:58 ` Christoph Lameter
2007-04-26 18:25 ` [PATCH] mm/memory.c: remove warning from an uninitialized spinlock. was: Re: 2.6.21-rc7-mm2 Borislav Petkov
2007-04-28 0:22 ` Andrew Morton
2007-04-28 0:27 ` Jeremy Fitzhardinge
2007-04-28 5:57 ` Borislav Petkov
2007-04-28 6:25 ` Borislav Petkov
2007-04-28 6:54 ` Andrew Morton
2007-04-28 7:03 ` Jeremy Fitzhardinge
2007-04-28 23:48 ` Andy Whitcroft
2007-04-29 3:25 ` Andrew Morton
2007-04-29 6:50 ` Borislav Petkov
2007-04-29 8:19 ` Andrew Morton
2007-04-29 9:24 ` Andrew Morton
2007-04-29 21:36 ` Dave Jones
2007-04-29 21:45 ` Andrew Morton
2007-11-07 19:20 ` Steven Rostedt
2007-11-08 5:15 ` Borislav Petkov
2007-04-26 23:47 ` [-mm patch] make drivers/hwmon/applesmc.c:backlight_work static Adrian Bunk
2007-04-26 23:47 ` [-mm patch] unexport highlevel_host_reset Adrian Bunk
2007-04-27 0:16 ` Stefan Richter
2007-04-27 2:31 ` 2.6.21-rc7-mm2 breaks 'lvm vgscan' Valdis.Kletnieks
2007-04-27 2:55 ` Andrew Morton
2007-05-05 18:04 ` Valdis.Kletnieks
2007-04-28 17:56 ` 2.6.21-rc7-mm2 crash: Eeek! page_mapcount(page) went negative! (-1) Tilman Schmidt
2007-04-28 21:10 ` Andrew Morton
2007-04-28 22:06 ` Hugh Dickins
2007-04-30 17:17 ` Tilman Schmidt
2007-04-30 18:21 ` Andrew Morton
2007-04-30 19:28 ` Tilman Schmidt
2007-04-30 19:46 ` Andrew Morton
2007-04-30 21:32 ` Tilman Schmidt
2007-05-01 11:26 ` Tilman Schmidt
2007-05-02 3:10 ` Greg KH
2007-05-02 7:01 ` Tilman Schmidt
2007-05-02 7:02 ` Greg KH
2007-05-02 7:10 ` Andrew Morton
2007-05-02 7:28 ` Greg KH
2007-05-02 7:43 ` Greg KH
2007-05-02 9:41 ` Tilman Schmidt
2007-05-02 22:06 ` Greg KH
2007-05-02 12:14 ` Kay Sievers
2007-05-02 7:52 ` Greg KH
2007-05-02 17:36 ` Tilman Schmidt
2007-05-02 20:07 ` Andrew Morton
2007-05-02 21:22 ` Tilman Schmidt
2007-05-02 7:10 ` Nick Piggin
2007-04-28 19:19 ` [-mm patch] make drivers/misc/thinkpad_acpi:fan_mutex static Adrian Bunk
2007-04-28 19:58 ` Henrique de Moraes Holschuh
2007-04-29 1:53 ` Len Brown
2007-04-29 2:50 ` Adrian Bunk
2007-04-29 4:09 ` Henrique de Moraes Holschuh [this message]
2007-04-28 19:19 ` [-mm patch] MMC: make tifm_sd_set_dma_data() static Adrian Bunk
2007-05-01 14:14 ` Pierre Ossman
2007-04-28 19:20 ` [-mm patch] drivers/rtc/rtc-dev.c should #include "rtc-core.h" Adrian Bunk
2007-04-28 19:20 ` [-mm patch] scsi/lpfc/lpfc_init.c: remove unused variable Adrian Bunk
2007-04-29 19:19 ` 2.6.21-rc7-mm2 Dan Kruchinin
2007-04-29 19:48 ` 2.6.21-rc7-mm2 Andrew Morton
2007-04-30 5:01 ` 2.6.21-rc7-mm2 hangs in boot Randy Dunlap
2007-04-30 5:23 ` Andrew Morton
2007-04-30 15:16 ` Randy Dunlap
2007-04-30 23:51 ` 2.6.21-rc7-mm2 hangs in boot (netconsole) Randy Dunlap
2007-05-01 0:12 ` Andrew Morton
2007-05-01 0:45 ` Randy Dunlap
2007-05-01 1:08 ` Andrew Morton
2007-05-01 3:43 ` Andi Kleen
2007-05-01 5:16 ` Randy Dunlap
2007-05-01 5:23 ` Andrew Morton
2007-05-01 6:24 ` Andi Kleen
2007-05-01 5:38 ` Andrew Morton
2007-05-01 16:15 ` Randy Dunlap
2007-05-01 6:22 ` Andi Kleen
2007-05-01 16:22 ` Randy Dunlap
2007-05-01 17:26 ` Randy Dunlap
2007-05-04 11:38 ` [PATCH] Re: 2.6.21-rc7-mm2 -- hvsi console driver registration failure Andy Whitcroft
2007-05-04 19:04 ` Linas Vepstas
2007-05-04 20:09 ` Andrew Morton
2007-05-04 21:21 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070429040953.GA29832@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®