From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946819AbXD3U7K (ORCPT ); Mon, 30 Apr 2007 16:59:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946820AbXD3U7K (ORCPT ); Mon, 30 Apr 2007 16:59:10 -0400 Received: from rgminet01.oracle.com ([148.87.113.118]:56512 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946819AbXD3U7H (ORCPT ); Mon, 30 Apr 2007 16:59:07 -0400 Date: Mon, 30 Apr 2007 14:02:38 -0700 From: Randy Dunlap To: David Rientjes Cc: David Brownell , linux-kernel@vger.kernel.org Subject: Re: [patch] pm: include EIO from errno-base.h Message-Id: <20070430140238.ff65e3e0.randy.dunlap@oracle.com> In-Reply-To: References: <200704300751.07078.david-b@pacbell.net> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.3.1 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Apr 2007 12:15:57 -0700 (PDT) David Rientjes wrote: > For backwards compatibility, call_platform_enable_wakeup() can return 0 > instead of -EIO since we aren't guaranteed to have errno defined. > > Cc: David Brownell > Signed-off-by: David Rientjes > --- > include/linux/pm.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/pm.h b/include/linux/pm.h > --- a/include/linux/pm.h > +++ b/include/linux/pm.h > @@ -328,7 +328,7 @@ static inline void dpm_runtime_resume(struct device * dev) > > static inline int call_platform_enable_wakeup(struct device *dev, int is_on) > { > - return -EIO; > + return 0; > } > > #endif Andrew, Can you fasttrack this one? otherwise allnoconfig fails. :( --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***