Re: [PATCH 2/3] UIO: Documentation

[Randy Dunlap <randy.dunlap@oracle.com>]

On Wed, 2 May 2007 10:41:35 +0200 Hans-Jürgen Koch wrote:

> Am Mittwoch 02 Mai 2007 01:42 schrieb Randy Dunlap:
> 
> > > +<title>The Userspace I/O HOWTO</title>
> > 
> > Most of this reads well.  Thanks.
> > A few typo corrections are below...
> 
> Thank you for your work. I generated a new patch that includes all your 
> suggestions and also fixes the build problems.

Hi,
What does your patch apply to, please?  I get patch errors with it.


> [...]
> > 
> > However, it still fails 'make htmldocs' for me.
> > What am I missing?  How did it work for you?
> > My DTD doesn't like to see <varname> inside a <listitem>:
> > 
> > 
> > linux-2.6.21-rc7-mm2/Documentation/DocBook/uio-howto.xml:333: element listitem: validity error : Element listitem content does not follow the DTD, expecting (calloutlist | glosslist | itemizedlist | orderedlist | segmentedlist | simplelist | variablelist | caution | important | note | tip | warning | literallayout | programlisting | programlistingco | screen | screenco | screenshot | synopsis | cmdsynopsis | funcsynopsis | classsynopsis | fieldsynopsis | constructorsynopsis | destructorsynopsis | methodsynopsis | formalpara | para | simpara | address | blockquote | graphic | graphicco | mediaobject | mediaobjectco | informalequation | informalexample | informalfigure | informaltable | equation | example | figure | table | msgset | procedure | sidebar | qandaset | anchor | bridgehead | remark | highlights | abstract | authorblurb | epigraph | indexterm | beginpage)+, got (varname CDATA)
> > 
> > 
> > so I removed most of the <varname>s and still had errors.
> > Any suggestions?
> 
> Yes, this only occurs when the <listitem> content is not surrounded by 
> <para></para>. I fixed that. I also changed the whole thing from
> "article" to "book" as all the other *.tmpl files are books. 
> 
> 
> [...]
> > > <listitem>
> > > +<varname>void *internal_addr</varname>: If you have to access this memory
> > > +region from within your kernel module, you will want to map it internally by
> > > +using something like <function>ioremap_nocache()</function>. Addresses
> > > +returned by this function can not be mapped to user space, so you must not
> > 
> >                              cannot
> 
> Here I also replaced ioremap_nocache() by ioremap(). I just fixed that in
> uio_cif.c and don't want to encourage other people to write the same nonsense.
> 
> Here's my patch, as I said, it should include your fixes as well:
> 
> Index: linux-2.6.22-rc/drivers/uio/uio.c


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***