From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dave Johnson <djohnson+linux-kernel@sw.starentnetworks.com>,
akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: do_tty_write() can block even with O_NONBLOCK?
Date: Wed, 2 May 2007 17:02:50 +0100 [thread overview]
Message-ID: <20070502170250.09ae354c@the-village.bc.nu> (raw)
In-Reply-To: <17976.43884.191895.235227@zeus.sw.starentnetworks.com>
On Wed, 2 May 2007 11:17:00 -0400
Dave Johnson <djohnson+linux-kernel@sw.starentnetworks.com> wrote:
>
> I have two processes with the same tty open, one opens blocking and
> one opens nonblocking.
>
> If the blocking process blocks doing a write (due to flow control,
> just going to fast, etc...) the nonblocking process will also block
> when it writes until the blocking process unblocks.
>
> This seems to occur because do_tty_write() isn't checking for
> O_NONBLOCK when taking the tty's write mutex.
>
>
> Signed-off-by: Dave Johnson <djohnson+linux-kernel@sw.starentnetworks.com>
Acked-by: Alan Cox <alan@redhat.com>
Looks fine to me.
prev parent reply other threads:[~2007-05-02 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 15:17 Dave Johnson
2007-05-02 16:02 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070502170250.09ae354c@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=djohnson+linux-kernel@sw.starentnetworks.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®