From: Eric Dumazet <dada1@cosmosbay.com>
To: James Pearson <james-p@moving-picture.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Don't truncate /proc/PID/environ at 4096 characters
Date: Fri, 4 May 2007 17:34:46 +0200 [thread overview]
Message-ID: <20070504173446.7ff0baef.dada1@cosmosbay.com> (raw)
In-Reply-To: <463B43A1.6050409@moving-picture.com>
On Fri, 04 May 2007 15:30:57 +0100
James Pearson <james-p@moving-picture.com> wrote:
> /proc/PID/environ currently truncates at 4096 characters, patch based on
> the /proc/PID/mem code.
>
> Signed-off-by: James Pearson <james-p@moving-picture.com>
>
What about latency when reading one *big* environ ?
Dont we need some cond_resched() test in the loop ?
> +
> +static struct file_operations proc_environ_operations = {
> + .read = environ_read,
> +};
> +
Please use the const qualifier here :
static const struct file_operations ...
Thank you
next prev parent reply other threads:[~2007-05-04 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 14:30 James Pearson
2007-05-04 15:34 ` Eric Dumazet [this message]
2007-05-08 10:43 ` James Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070504173446.7ff0baef.dada1@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=james-p@moving-picture.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome