From: Andreas Mohr <andi@rhlx01.hs-esslingen.de>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Thomas Gleixner <tglx@linutronix.de>,
john stultz <johnstul@us.ibm.com>, Andi Kleen <ak@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
"Guilherme M. Schroeder" <guilherme@centralinf.com.br>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Blacklist Dell Optiplex 320 from using the HPET
Date: Mon, 7 May 2007 20:59:02 +0200 [thread overview]
Message-ID: <20070507185902.GA11048@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <20070505155815.GC15620@khazad-dum.debian.net>
Hi,
On Sat, May 05, 2007 at 12:58:15PM -0300, Henrique de Moraes Holschuh wrote:
> On Sat, 05 May 2007, Thomas Gleixner wrote:
> > + printk(KERN_WARNING "HPET counter is defect\n");
>
> What about
> printk(KERN_WARNING "HPET counter is stopped\n");
>
> which is far more descriptive?
Far more misguiding, rather?
People may mistake this (when not realizing the KERN_WARNING output)
as a status message indicating that we actively stopped the counter.
Maybe something like
"HPET counter inoperable or defective (no increment found during probing)"?
(with an optional "please report" part)
Andreas Mohr
next prev parent reply other threads:[~2007-05-07 18:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 21:29 john stultz
2007-05-04 21:44 ` Andrew Morton
2007-05-04 21:47 ` john stultz
2007-05-04 23:19 ` Andi Kleen
2007-05-04 23:18 ` Andi Kleen
2007-05-04 23:27 ` john stultz
2007-05-05 14:26 ` Thomas Gleixner
2007-05-05 14:30 ` Thomas Gleixner
2007-05-05 15:58 ` Henrique de Moraes Holschuh
2007-05-07 18:59 ` Andreas Mohr [this message]
2007-05-07 20:41 ` Henrique de Moraes Holschuh
2007-05-05 17:24 ` Andi Kleen
2007-05-05 19:15 ` Thomas Gleixner
2007-05-05 22:05 ` Andi Kleen
2007-05-05 22:41 ` Guilherme M. Schroeder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070507185902.GA11048@rhlx01.hs-esslingen.de \
--to=andi@rhlx01.hs-esslingen.de \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=guilherme@centralinf.com.br \
--cc=hmh@hmh.eng.br \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®