From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Linux Kernel List <linux-kernel@vger.kernel.org>,
Timur Tabi <timur@freescale.com>,
Michael Schmitz <schmitz@opal.biophys.uni-duesseldorf.de>
Subject: select is evil: another reason
Date: Wed, 9 May 2007 10:13:58 +0100 [thread overview]
Message-ID: <20070509091358.GA29994@flint.arm.linux.org.uk> (raw)
drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' refers to undefined symbol 'UCC_FAST'
drivers/input/keyboard/Kconfig:170:warning: 'select' used by config symbol 'KEYBOARD_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'
drivers/input/mouse/Kconfig:161:warning: 'select' used by config symbol 'MOUSE_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'
The select statements are in generic Kconfig files. The symbols they
are selecting are in arch-private Kconfig files. Don't do that -
those symbols are undefined for other architectures.
If you must do that then do:
config ATARI_KBD_CORE
bool
+ default y if KEYBOARD_ATARI || MOUSE_ATARI
in our m68k Kconfig file, and in arch/powerpc/sysdev/qe_lib/Kconfig:
config UCC_FAST
bool
- default n
+ default y if UCC_GETH
and kill those three select statements in the generic Kconfig files.
Note also that the select in:
config UCC_FAST
bool
default n
select UCC
config UCC
bool
default y if UCC_FAST || UCC_SLOW
is absolutely absurd. Either use select in UCC_FAST _or_ default y if ...
in UCC but not both.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next reply other threads:[~2007-05-09 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-09 9:13 Russell King [this message]
2007-05-10 8:57 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509091358.GA29994@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=schmitz@opal.biophys.uni-duesseldorf.de \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome