From: Anton Vorontsov <cbou@mail.ru>
To: Miles Lane <miles.lane@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.21-mm2 -- Compile error: include/linux/power_supply.h:125: error: field ‘changed_work’ has incomplete type
Date: Wed, 9 May 2007 14:50:20 +0400 [thread overview]
Message-ID: <20070509105019.GA20209@zarina> (raw)
In-Reply-To: <a44ae5cd0705090343n6ddae15he51198a0e448198a@mail.gmail.com>
On Wed, May 09, 2007 at 03:43:34AM -0700, Miles Lane wrote:
> CC drivers/power/power_supply_core.o
> In file included from drivers/power/power_supply_core.c:18:
> include/linux/power_supply.h:125: error: field 'changed_work' has
> incomplete type
> drivers/power/power_supply_core.c: In function 'power_supply_changed_work':
> drivers/power/power_supply_core.c:25: warning: type defaults to 'int'
> in declaration of '__mptr'
> drivers/power/power_supply_core.c:25: warning: initialization from
> incompatible pointer type
> drivers/power/power_supply_core.c: In function 'power_supply_changed':
> drivers/power/power_supply_core.c:57: warning: implicit declaration of
> function 'schedule_work'
> drivers/power/power_supply_core.c: In function 'power_supply_register':
> drivers/power/power_supply_core.c:103: warning: implicit declaration
> of function 'INIT_WORK'
> drivers/power/power_supply_core.c: In function 'power_supply_unregister':
> drivers/power/power_supply_core.c:128: warning: implicit declaration
> of function 'flush_scheduled_work'
> make[2]: *** [drivers/power/power_supply_core.o] Error 1
Oh oh.. yet another refactors in -mm. It compiles clean on bare
2.6.21, though. But power_supply.h is indeed wrong, it assumed that
workqueue.h included by other headers, it is not. I hope following patch
will fix it.
diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index 14e617b..2f47df7 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -14,6 +14,7 @@
#define __LINUX_POWER_SUPPLY_H__
#include <linux/device.h>
+#include <linux/workqueue.h>
#include <linux/leds.h>
/*
prev parent reply other threads:[~2007-05-09 10:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-09 10:43 Miles Lane
2007-05-09 10:50 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509105019.GA20209@zarina \
--to=cbou@mail.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miles.lane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®