From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758762AbXEIUt3 (ORCPT ); Wed, 9 May 2007 16:49:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758587AbXEIUtS (ORCPT ); Wed, 9 May 2007 16:49:18 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:51127 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755081AbXEIUtQ (ORCPT ); Wed, 9 May 2007 16:49:16 -0400 From: "Rafael J. Wysocki" To: tglx@linutronix.de Subject: Re: [patch 3/3] clockevents: Fix resume logic - updated version Date: Wed, 9 May 2007 22:53:49 +0200 User-Agent: KMail/1.9.5 Cc: Andrew Morton , Ingo Molnar , LKML , John Stultz , linux-acpi@vger.kernel.org References: <20070430102837.748238000@linutronix.de> <200705092036.20953.rjw@sisk.pl> <1178743550.3042.541.camel@localhost.localdomain> In-Reply-To: <1178743550.3042.541.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200705092253.49896.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, 9 May 2007 22:45, Thomas Gleixner wrote: > On Wed, 2007-05-09 at 20:36 +0200, Rafael J. Wysocki wrote: > > Well, apparently, not in -mm2: > > > > rafael@albercik:~/src/mm/linux-2.6.21-mm2> grep -r -I -l 'timekeeping_resume' * > > kernel/time/timekeeping.c > > rafael@albercik:~/src/mm/linux-2.6.21-mm2> grep clocksource_resume kernel/time/timekeeping.c > > rafael@albercik:~/src/mm/linux-2.6.21-mm2> > > Andrew dropped the patch because it did not work on his jinxed VAIO, but > he debugged with the patch applied. I see. In that case, since timekeeping_resume() is called via sysdev_resume, then it's executed before acpi_leave_sleep_state() and may very well interfere with the ACPI methods executed from there, depending on what's happening in the cs->resume() callbacks in clocksource_resume(). Greetings, Rafael